FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test,benchmark: use `tmpdir.fileURL()` by LiviaMedeiros · Pull Request #49138 · nodejs/node · GitHub

/ node Public

test,benchmark: use tmpdir.fileURL() - #49138

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
LiviaMedeiros:test-tmpdir-fileurl-leftover
Aug 21, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test,benchmark: use tmpdir.fileURL()#49138
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
LiviaMedeiros:test-tmpdir-fileurl-leftover

Conversation

LiviaMedeiros commented Aug 13, 2023

Copy link
Copy Markdown
Member

Refs: #49040

nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Aug 13, 2023

This comment was marked as outdated.

Sign in to view
github-actions Bot mentioned this pull request Aug 14, 2023
Open
25 tasks

This comment was marked as outdated.

Sign in to view
github-actions Bot mentioned this pull request Aug 16, 2023
Open
24 tasks

This comment was marked as outdated.

Sign in to view
github-actions Bot mentioned this pull request Aug 17, 2023
Open
26 tasks

nodejs-github-bot commented Aug 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53397/

LiviaMedeiros added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 17, 2023
This was referenced Aug 18, 2023
Open
Open
LiviaMedeiros added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 21, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 21, 2023
nodejs-github-bot merged commit eeddbfa into nodejs:main Aug 21, 2023

nodejs-github-bot commented Aug 21, 2023

Copy link
Copy Markdown
Collaborator

Landed in eeddbfa

UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
test,benchmark: use tmpdir.fileURL()
fac56db 
PR-URL: #49138
Refs: #49040
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon mentioned this pull request Sep 10, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
test,benchmark: use tmpdir.fileURL()
b011a49 
PR-URL: #49138
Refs: #49040
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test,benchmark: use tmpdir.fileURL()
bdcdb85 
PR-URL: nodejs/node#49138
Refs: nodejs/node#49040
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test,benchmark: use tmpdir.fileURL()
1eea878 
PR-URL: nodejs/node#49138
Refs: nodejs/node#49040
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL