FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: use exact return value for `uv_os_getenv` by anonrig · Pull Request #49149 · nodejs/node · GitHub

/ node Public

src: use exact return value for uv_os_getenv - #49149

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:use-libuv-flag
Sep 30, 2023
Merged

src: use exact return value for uv_os_getenv#49149
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:use-libuv-flag

Conversation

anonrig commented Aug 13, 2023

Copy link
Copy Markdown
Member

uv_os_getenv returns 0 for happy path.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 13, 2023
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 13, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 13, 2023

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

anonrig added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 29, 2023

Copy link
Copy Markdown
Collaborator

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2023

Copy link
Copy Markdown
Collaborator

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2023
nodejs-github-bot merged commit b903a71 into nodejs:main Sep 30, 2023

Copy link
Copy Markdown
Collaborator

Landed in b903a71

targos pushed a commit that referenced this pull request Nov 11, 2023
PR-URL: #49149
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
PR-URL: nodejs#49149
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL