test: fix compiler warning in NodeCryptoEnv - #49206
Merged
nodejs-github-bot merged 1 commit intoAug 24, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This fixes a warning in line 26: "warning: value computed is not used" when calling BIO_seek(). Refs: nodejs#47160
This comment was marked as outdated.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mhdawson
approved these changes
Aug 23, 2023
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
27 tasks
This was referenced Aug 25, 2023
Merged
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
This fixes a warning in line 26: "warning: value computed is not used" when calling BIO_seek(). Refs: nodejs/node#47160 PR-URL: nodejs/node#49206 Reviewed-By: Michael Dawson <midawson@redhat.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
This fixes a warning in line 26: "warning: value computed is not used" when calling BIO_seek(). Refs: nodejs/node#47160 PR-URL: nodejs/node#49206 Reviewed-By: Michael Dawson <midawson@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes warning: value computed is not used when calling BIO_seek():
../test/cctest/test_node_crypto_env.cc: In member function ‘virtual void NodeCryptoEnv_LoadBIO_Test::TestBody()’: ../deps/openssl/openssl/include/openssl/../../../config/././archs/linux-x86_64/asm/include/openssl/bio.h:495:26: warning: value computed is not used [-Wunused-value] 495 | # define BIO_seek(b,ofs) (int)BIO_ctrl(b,BIO_C_FILE_SEEK,ofs,NULL) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../test/cctest/test_node_crypto_env.cc:26:3: note: in expansion of macro ‘BIO_seek’ 26 | BIO_seek(bio.get(), 2); | ^~~~~~~~Refs: #47160