src: remove unnecessary todo - #49227
Merged
nodejs-github-bot merged 1 commit intoSep 21, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
anonrig
reviewed
Aug 19, 2023
Comment thread
src/node_file.cc
anonrig
approved these changes
Aug 19, 2023
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/49227 ✔ Done loading data for nodejs/node/pull/49227 ----------------------------------- PR info ------------------------------------ Title src: remove unnecessary todo (#49227) Author Rafael Gonzaga (@RafaelGSS) Branch RafaelGSS:remove/unnecessary-todo -> nodejs:main Labels c++, fs Commits 1 - src: remove unnecessary todo Committers 1 - RafaelGSS PR-URL: https://github.com/nodejs/node/pull/49227 Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49227 Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 18 Aug 2023 13:57:02 GMT ✔ Approvals: 1 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49227#pullrequestreview-1585654879 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6203730011 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I've removed the needs-ci label, but the commit-queue fails anyway. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Sep 16, 2023
UlisesGascon
approved these changes
Sep 16, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Sep 17, 2023
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
PR-URL: #49227 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not necessary anymore