FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: fix fs_type_to_name default value by 0o001 · Pull Request #49239 · nodejs/node · GitHub

/ node Public

src: fix fs_type_to_name default value - #49239

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
0o001:node-2
Sep 7, 2023
ConversationCommits (1)ChecksFiles changed
Merged

src: fix fs_type_to_name default value#49239
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
0o001:node-2

Conversation

0o001 commented Aug 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Aug 19, 2023
0o001 changed the title src: fs_type_to_name default value src: fix fs_type_to_name default value Aug 20, 2023

aduh95 commented Aug 28, 2023

Copy link
Copy Markdown
Contributor

@nodejs/fs

LiviaMedeiros approved these changes Aug 28, 2023
View reviewed changes

LiviaMedeiros left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks for the contribution!

LiviaMedeiros added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 28, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 28, 2023

nodejs-github-bot commented Aug 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53591/

nodejs-github-bot commented Aug 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53595/

This was referenced Aug 29, 2023
Open
Open
Open
Open
Open

nodejs-github-bot commented Sep 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53764/

nodejs-github-bot commented Sep 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53774/

nodejs-github-bot commented Sep 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53790/

LiviaMedeiros added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 7, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 7, 2023
nodejs-github-bot merged commit 0bce573 into nodejs:main Sep 7, 2023

nodejs-github-bot commented Sep 7, 2023

Copy link
Copy Markdown
Collaborator

Landed in 0bce573

This was referenced Sep 8, 2023
Open
Open
Open
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
src: fix fs_type_to_name default value
2d3f5c7 
PR-URL: #49239
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: theanarkh <theratliter@gmail.com>
This was referenced Sep 28, 2023
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tniessen tniessen approved these changes
theanarkh theanarkh approved these changes
LiviaMedeiros LiviaMedeiros approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL