doc: use NODE_API_SUPPORTED_VERSION_MAX in release doc - #49268
Closed
zcbenz wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
bnoordhuis
approved these changes
Aug 21, 2023
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Suggestion: reference commit 6ffacbf in the commit log (edit: or the PR URL.)
Sorry, something went wrong.
The code was changed in nodejs#48501 but the doc was missed.
mhdawson
approved these changes
Aug 22, 2023
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
legendecas
approved these changes
Aug 22, 2023
Merged
27 tasks
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
The code was changed in #48501 but the doc was missed. PR-URL: nodejs/node#49268 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
The code was changed in #48501 but the doc was missed. PR-URL: nodejs/node#49268 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the doc for the changes in #48501.