fs: remove redundant code in readableWebStream() - #49298
Merged
nodejs-github-bot merged 1 commit intoAug 25, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Remove redundant code by moving it to outside of `if/else`. Plus, make `options` optional in doc.
debadree25
approved these changes
Aug 24, 2023
debadree25
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks 😄
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Aug 24, 2023
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
Remove redundant code by moving it to outside of `if/else`. Plus, make `options` optional in doc. PR-URL: #49298 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
Remove redundant code by moving it to outside of `if/else`. Plus, make `options` optional in doc. PR-URL: #49298 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Remove redundant code by moving it to outside of `if/else`. Plus, make `options` optional in doc. PR-URL: nodejs/node#49298 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Remove redundant code by moving it to outside of `if/else`. Plus, make `options` optional in doc. PR-URL: nodejs/node#49298 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundant code by moving it to outside of if/else. Plus, make options optional in doc.
Below code is duplicated because it exists on both if and else.
const { readableStreamCancel, } = require('internal/webstreams/readablestream'); this[kRef](); this.once('close', () => { readableStreamCancel(readable); });And options param is optional like below.
/** * @typedef {import('../webstreams/readablestream').ReadableStream * } ReadableStream * @param {{ * type?: string; * }} [options] * @returns {ReadableStream} */ readableWebStream(options = kEmptyObject) {