| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
Isn't it possible to reconstruct the download URL from the NODE_VERSION_* macros in src/node_version.h? The approach you've taken is not bad but it's considerably more complex than is strictly necessary, I think.
Sorry, something went wrong.
There was a problem hiding this comment.
Yes ... this is an option but this gives us more flexibility for testing and baking in arbitrary urls to releases including nightlies, I can hardwire the host in here and handle the nightlies special case with macros if you think that's the best way to go. For now this is really helpful for testing this feature so I'll leave it asis.
Sorry, something went wrong.
|
I like this 😄 A thought: Is perhaps process.release a bit redundant with process.config? I'm thinking it would be simpler if we just re-used that mechanism, since whatever's in config.gypi will be on that object during runtime (would make the changes in node.gyp and src/node.cc unnecessary). We would just need to move the 3 URL props to the root-level of the config.gypi file, and add config.name = 'iojs' in the configure phase, so that it ends up in the config.gypi file as well. |
Sorry, something went wrong.
|
@TooTallNate that's a good suggestion; I'm working my way through some node-gyp changes for this and that's the really difficult end so I'll loop back here when I have something working over there. |
Sorry, something went wrong.
|
@rvagg is anything still holding this up? |
Sorry, something went wrong.
|
Yes, I'm the holdup, we need to arrive on code that's acceptable to both node-gyp and io.js before we can land either. The current state of code is @ https://github.com/rvagg/node-gyp/compare/iojs?expand=1 but it's pending proper Windows support, it's only part-way there. I'll try and get to it this week but if I keep finding that I just don't have time to finish it up I'll put out a call for someone else to take over. |
Sorry, something went wrong.
|
Didn't I see windows gyp support land? Does that unblock this? |
Sorry, something went wrong.
|
What is the status here? Anything you need help with @rvagg? |
Sorry, something went wrong.
|
This is still blocking nodejs/node-gyp#564, which is in turn blocking npm from shipping a floating-patch free version of itself. Is there anything I can do to move this along, @rvagg? |
Sorry, something went wrong.
|
@rvagg now that you're less busy, any chance of this landing soon? Seems like a few people depend on this. |
Sorry, something went wrong.
|
.................................. |
Sorry, something went wrong.
|
@stevenvachon it'd be great if you avoided comments like these. Since a lot of people get pinged when new info arrives, we also assume that information will be beneficial to us. Thanks for understanding. |
Sorry, something went wrong.
|
@jbergstroem and other comments merely asking for status updates shouldn't also be avoided? |
Sorry, something went wrong.
while we're waiting on nodejs/node#493
Sorry, something went wrong.
|
I do dis ... it's becoming more and more urgent; I just have to squash a . few . more . things . from . my . TODO |
Sorry, something went wrong.
|
Hmm, semver-minor.. no way to port this to 1.x then? It'd probably be worth it. |
Sorry, something went wrong.
|
@Fishrock123 if the LTS working group wills it, I'm sure they can make it happen. |
Sorry, something went wrong.
|
Looks good, when to merge? |
Sorry, something went wrong.
|
Is this necessary anymore since http://www.infoq.com/news/2015/05/nodejs-iojs ? |
Sorry, something went wrong.
|
Yes because 1) io.js still exists and is still releasing and has a patched version of node-gyp that you can't upgrade and more importantly 2) we need to support nightlies and rc builds with node-gyp and this metadata provides us with the flexibility to do so. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
I'm messing around in node-gyp to see how workable this is and I haven't actually tested this on Windows yet although I've modified vcbuild.bat. Putting this up early to get feedback.
supersedes #491 and see also nodejs/node-gyp#564 for further discussion and an apparent 👍 from @TooTallNate on the proposal.