FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

node-api: enable uncaught exceptions policy by default by legendecas · Pull Request #49313 · nodejs/node · GitHub

/ node Public

node-api: enable uncaught exceptions policy by default - #49313

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
legendecas:node-api/uncaught-exception
Sep 25, 2023
ConversationCommits (2)ChecksFiles changed
Merged

node-api: enable uncaught exceptions policy by default#49313
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
legendecas:node-api/uncaught-exception

Conversation

legendecas commented Aug 24, 2023

Copy link
Copy Markdown
Member

This enables the option --force-node-api-uncaught-exceptions-policy
for a specific Node-API addon when it is compiled with
NAPI_EXPERIMENTAL (and this would be the default behavior when
NAPI_VERSION 10 releases). This would not break existing Node-API
addons.

Refs: #36510

nodejs-github-bot commented Aug 24, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/node-api

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. labels Aug 24, 2023
mhdawson approved these changes Aug 25, 2023
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 25, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 25, 2023

nodejs-github-bot commented Aug 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53555/

mhdawson mentioned this pull request Aug 25, 2023
Closed
This was referenced Aug 26, 2023
Open
Open
Open
Open
Open

nodejs-github-bot commented Sep 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53776/

gabrielschulhof commented Sep 8, 2023

Copy link
Copy Markdown
Contributor

It would be best to land this after #49515.

node-api: enable uncaught exceptions policy by default
bcda6c4 
This enables the option `--force-node-api-uncaught-exceptions-policy`
for a specific Node-API addon when it is compiled with
`NAPI_EXPERIMENTAL` (and this would be the default behavior when
`NAPI_VERSION` 10 releases). This would not break existing Node-API
addons.
legendecas force-pushed the node-api/uncaught-exception branch from 2efb890 to bcda6c4 Compare September 11, 2023 17:25
legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2023

nodejs-github-bot commented Sep 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53904/

toyobayashi mentioned this pull request Sep 14, 2023
Merged
gabrielschulhof reviewed Sep 15, 2023
View reviewed changes
Comment thread doc/api/n-api.md Outdated
Comment thread test/node-api/test_threadsafe_function/test_uncaught_exception.js Outdated
const binding = require(`./build/${common.buildType}/binding`);
const binding = require(`./build/${common.buildType}/test_uncaught_exception`);

const callbackCheck = common.mustCall((err) => {

gabrielschulhof Sep 15, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Would it be possible to put this code in a common module? That would make it clear that the same test is supposed to work with both versions, and only the preprocessor flags and the node launch flags differ. I think files not starting with test_ are not executed when the test suite runs.

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2023

nodejs-github-bot commented Sep 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54184/

github-actions Bot mentioned this pull request Sep 24, 2023
Open
20 tasks

nodejs-github-bot commented Sep 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54193/

legendecas added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Sep 25, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 25, 2023
nodejs-github-bot merged commit 77597d3 into nodejs:main Sep 25, 2023

nodejs-github-bot commented Sep 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in 77597d3

joyeecheung mentioned this pull request Sep 25, 2023
Closed
github-actions Bot mentioned this pull request Sep 27, 2023
Open
21 tasks
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
node-api: enable uncaught exceptions policy by default
9600928 
This enables the option `--force-node-api-uncaught-exceptions-policy`
for a specific Node-API addon when it is compiled with
`NAPI_EXPERIMENTAL` (and this would be the default behavior when
`NAPI_VERSION` 10 releases). This would not break existing Node-API
addons.

PR-URL: #49313
Refs: #36510
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
ruyadorno mentioned this pull request Sep 28, 2023
Closed
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
node-api: enable uncaught exceptions policy by default
96874e8 
This enables the option `--force-node-api-uncaught-exceptions-policy`
for a specific Node-API addon when it is compiled with
`NAPI_EXPERIMENTAL` (and this would be the default behavior when
`NAPI_VERSION` 10 releases). This would not break existing Node-API
addons.

PR-URL: #49313
Refs: #36510
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
ruyadorno mentioned this pull request Sep 28, 2023
Merged
legendecas deleted the node-api/uncaught-exception branch October 24, 2023 06:57
targos pushed a commit that referenced this pull request Nov 27, 2023
node-api: enable uncaught exceptions policy by default
edef4fa 
This enables the option `--force-node-api-uncaught-exceptions-policy`
for a specific Node-API addon when it is compiled with
`NAPI_EXPERIMENTAL` (and this would be the default behavior when
`NAPI_VERSION` 10 releases). This would not break existing Node-API
addons.

PR-URL: #49313
Refs: #36510
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
node-api: enable uncaught exceptions policy by default
2bba1c9 
This enables the option `--force-node-api-uncaught-exceptions-policy`
for a specific Node-API addon when it is compiled with
`NAPI_EXPERIMENTAL` (and this would be the default behavior when
`NAPI_VERSION` 10 releases). This would not break existing Node-API
addons.

PR-URL: nodejs/node#49313
Refs: nodejs/node#36510
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
node-api: enable uncaught exceptions policy by default
072c20a 
This enables the option `--force-node-api-uncaught-exceptions-policy`
for a specific Node-API addon when it is compiled with
`NAPI_EXPERIMENTAL` (and this would be the default behavior when
`NAPI_VERSION` 10 releases). This would not break existing Node-API
addons.

PR-URL: nodejs/node#49313
Refs: nodejs/node#36510
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gabrielschulhof gabrielschulhof approved these changes
+1 more reviewer
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL