src: remove unused PromiseWrap-related code - #49335
Merged
nodejs-github-bot merged 1 commit intoSep 1, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
PromiseWrap has been removed in nodejs#39135 and we do not have any internal object setting the internal field at 0 as a promise (we always set the first field as an aligned pointer to the embedder ID). As result GetAssignedPromiseWrapAsyncId() always just returns AsyncWrap::kInvalidAsyncId and turn the removed block into noops. So the block just can be removed.
Copy link
Copy Markdown
Member
Author
|
Also see the coverage report which shows that the code is unused and always just returns AsyncWrap::kInvalidAsyncId: https://app.codecov.io/gh/nodejs/node/commit/4ba73706507aebbd746838e903e38d568ca87e9d/blob/src/node_task_queue.cc#L54 |
Sorry, something went wrong.
This comment was marked as outdated.
lpinca
approved these changes
Aug 26, 2023
25 tasks
This comment was marked as outdated.
25 tasks
RaisinTen
approved these changes
Aug 28, 2023
This was referenced Aug 29, 2023
This comment was marked as outdated.
20 tasks
Flarna
approved these changes
Sep 1, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Sep 2, 2023
25 tasks
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
PromiseWrap has been removed in #39135 and we do not have any internal object setting the internal field at 0 as a promise (we always set the first field as an aligned pointer to the embedder ID). As result GetAssignedPromiseWrapAsyncId() always just returns AsyncWrap::kInvalidAsyncId and turn the removed block into noops. So the block just can be removed. PR-URL: #49335 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PromiseWrap has been removed in
#39135 and we do not have any internal object setting the internal field at 0 as a promise (we always set the first field as an aligned pointer to the embedder ID). As result GetAssignedPromiseWrapAsyncId() always just returns AsyncWrap::kInvalidAsyncId and turn the removed block into noops. So the block just can be removed.