FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: rename test-crypto-modp1-error by tniessen · Pull Request #49348 · nodejs/node · GitHub

/ node Public

test: rename test-crypto-modp1-error - #49348

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:test-rename-modp1
Aug 29, 2023
Merged

test: rename test-crypto-modp1-error#49348
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:test-rename-modp1

Conversation

Copy link
Copy Markdown
Member

This test is not specific to 'modp1' at all, it might as well use any of the other groups.

Refs: #40451

This test is not specific to modp1 at all, it might as well use any of
the other groups.

Refs: nodejs#40451
tniessen added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. labels Aug 27, 2023
nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 27, 2023
panva added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 28, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 28, 2023

This comment was marked as outdated.

This comment was marked as outdated.

Copy link
Copy Markdown
Member Author

CI infra is broken, see nodejs/build#3475.

Copy link
Copy Markdown
Collaborator

tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 29, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 29, 2023
nodejs-github-bot merged commit 452bae1 into nodejs:main Aug 29, 2023

Copy link
Copy Markdown
Collaborator

Landed in 452bae1

UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
This test is not specific to modp1 at all, it might as well use any of
the other groups.

Refs: #40451
PR-URL: #49348
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon mentioned this pull request Sep 10, 2023
targos pushed a commit that referenced this pull request Nov 27, 2023
This test is not specific to modp1 at all, it might as well use any of
the other groups.

Refs: #40451
PR-URL: #49348
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
This test is not specific to modp1 at all, it might as well use any of
the other groups.

Refs: nodejs/node#40451
PR-URL: nodejs/node#49348
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
This test is not specific to modp1 at all, it might as well use any of
the other groups.

Refs: nodejs/node#40451
PR-URL: nodejs/node#49348
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL