doc: fix node-api call example - #49395
Merged
nodejs-github-bot merged 1 commit intoAug 31, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The `return` statement should not be enclosed in a nested conditional branch.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
tniessen
approved these changes
Aug 28, 2023
daeyeon
approved these changes
Aug 29, 2023
HarshithaKP
approved these changes
Aug 29, 2023
lpinca
approved these changes
Aug 29, 2023
mhdawson
approved these changes
Aug 29, 2023
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
aymen94
approved these changes
Aug 31, 2023
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
The `return` statement should not be enclosed in a nested conditional branch. PR-URL: #49395 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
The `return` statement should not be enclosed in a nested conditional branch. PR-URL: #49395 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
The `return` statement should not be enclosed in a nested conditional branch. PR-URL: nodejs/node#49395 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
The `return` statement should not be enclosed in a nested conditional branch. PR-URL: nodejs/node#49395 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The return statement should not be enclosed in a nested conditional
branch.
Also, the NAPI_CALL macro is renamed to NODE_API_CALL in aligning
with the n-api to node-api transition.
Fixes #49311