esm: refactor mocking test - #49465
Merged
nodejs-github-bot merged 6 commits intoSep 5, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
JakobJingleheimer
approved these changes
Sep 3, 2023
JakobJingleheimer
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
🙌 wow! we should use this before & after as a poster-child for register & initialize
Sorry, something went wrong.
aduh95
reviewed
Sep 3, 2023
Comment thread
test/es-module/test-esm-loader-mock.mjs
Outdated
Comment thread
test/es-module/test-esm-loader-mock.mjs
Outdated
Comment thread
test/es-module/test-esm-loader-mock.mjs
Outdated
Comment thread
test/es-module/test-esm-loader-mock.mjs
Outdated
Comment thread
test/fixtures/es-module-loaders/mock-loader.mjs
Outdated
Comment thread
test/fixtures/es-module-loaders/mock-loader.mjs
Outdated
Comment thread
test/es-module/test-esm-loader-mock.mjs
Outdated
aduh95
reviewed
Sep 3, 2023
Comment thread
test/es-module/test-esm-loader-mock.mjs
Outdated
aduh95
reviewed
Sep 3, 2023
Comment thread
test/fixtures/es-module-loaders/mock-loader.mjs
Outdated
aduh95
reviewed
Sep 3, 2023
Comment thread
test/fixtures/es-module-loaders/mock-loader.mjs
Outdated
aduh95
reviewed
Sep 3, 2023
Comment thread
test/es-module/test-esm-loader-mock.mjs
Outdated
aduh95
reviewed
Sep 3, 2023
Comment thread
test/es-module/test-esm-loader-mock.mjs
Outdated
aduh95
reviewed
Sep 3, 2023
Comment thread
test/fixtures/es-module-loaders/mock.mjs
Outdated
aduh95
force-pushed
the
refactor-mocking-test
branch
from
bcb1837 to
d1bedb7
Compare
September 3, 2023 18:48
GeoffreyBooth
commented
Sep 3, 2023
Comment thread
test/fixtures/es-module-loaders/mock-loader.mjs
Outdated
aduh95
reviewed
Sep 3, 2023
Comment thread
test/fixtures/es-module-loaders/mock-loader.mjs
Outdated
aduh95
approved these changes
Sep 4, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
19 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Sep 6, 2023
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
PR-URL: #49465 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Nov 11, 2023
PR-URL: nodejs#49465 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49465 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49465 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors test/es-module/test-esm-loader-mock.mjs to use the new register and initialize APIs instead of globalPreload and setImportMetaCallback. I tried to preserve as much of the previous test as possible; all of the assertions from the earlier version are unchanged. This test passes both here, on main, and within #49144.
The largest addition to test-esm-loader-mock.mjs was code that just moved there from within the insideAppContext function in mock-loader.mjs.
@nodejs/loaders