doc: Fix Script with 'process,' 'path,' and 'run' Requires - #49490
doc: Fix Script with 'process,' 'path,' and 'run' Requires#49490OshriAsulin wants to merge 1 commit into
Conversation
Sorry, something went wrong.
This commit enhances the script by addressing missing imports for the 'run' function and the 'path' module, which previously resulted in script failure. The following improvements have been made: - Imported 'run' from the appropriate module via require to ensure correct functionality. - Imported 'path' via require to facilitate proper file path resolution. - Imported 'process' via require to include this essential module. These changes resolve the issue of missing dependencies execution.
|
Review requested:
|
Sorry, something went wrong.
|
Can you please unify the two PR's? |
Sorry, something went wrong.
|
Yes, and I need to create a new pull request after I have connected both branches together locally and pushed the unified branch to GitHub, right? @MoLow |
Sorry, something went wrong.
|
process is actually globally available so I'm not sure why we'd require it? |
Sorry, something went wrong.
You don't need to create a third PR, and it would actually be better if you didn't. My suggestion would be to edit the file at https://github.com/OshriAsulin/node/edit/patch-1/doc/api/test.md?pr=%2Fnodejs%2Fnode%2Fpull%2F49489 to include the changes on the script, and then to close this PR. |
Sorry, something went wrong.
This commit enhances the script by addressing missing imports for the 'run' function and the 'path' module, which previously resulted in script failure. The following improvements have been made:
These changes resolve the issue of missing dependencies execution.
This pr is a continuation of pr #49489