FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: V8: cherry-pick b60a03df4ceb by joyeecheung · Pull Request #49491 · nodejs/node · GitHub

/ node Public

deps: V8: cherry-pick b60a03df4ceb - #49491

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:backport-script
Sep 12, 2023
ConversationCommits (1)ChecksFiles changed
Merged

deps: V8: cherry-pick b60a03df4ceb#49491
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:backport-script

Conversation

joyeecheung commented Sep 4, 2023

Copy link
Copy Markdown
Member

Original commit message:

[api] mark v8::Script and v8::UnboundScript as v8::Data

v8::UnboundModuleScript and v8::Module are already v8::Data.
Mark v8::Script and v8::UnboundScript as v8::Data so that they
can be used in other V8 APIs that takes v8::Data.

Refs: https://github.com/nodejs/node/pull/48510

Bug: v8:14120
Change-Id: I2dd5648528c1b0030292872441758d4fb2cfcc1c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4827307
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Cr-Commit-Position: refs/heads/main@{#89727}

Refs: v8/v8@b60a03d

nodejs-github-bot commented Sep 4, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Sep 4, 2023

joyeecheung commented Sep 4, 2023

Copy link
Copy Markdown
Member Author

This can't land on v20.x for now because it can break the ABI - we could consider an exception if we think that the series of memory issues caused by the module/scripts should be fixed in the LTS given their impact. But before that we should wait until #48510 lands and gets released and tested in the wild to see if this is really necessary for 20.x.

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2023

nodejs-github-bot commented Sep 8, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5549/

nodejs-github-bot commented Sep 8, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5549/

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2023

nodejs-github-bot commented Sep 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53814/

nodejs-github-bot commented Sep 8, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5549/

nodejs-github-bot commented Sep 8, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5550/

nodejs-github-bot commented Sep 8, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5550/

nodejs-github-bot commented Sep 8, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5550/

joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 11, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 11, 2023

nodejs-github-bot commented Sep 11, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49491
✔  Done loading data for nodejs/node/pull/49491
----------------------------------- PR info ------------------------------------
Title      deps: V8: cherry-pick b60a03df4ceb (#49491)
Author     Joyee Cheung  (@joyeecheung)
Branch     joyeecheung:backport-script -> nodejs:main
Labels     build, v8 engine, needs-ci, dont-land-on-v20.x
Commits    1
 - deps: V8: cherry-pick b60a03df4ceb
Committers 1
 - Joyee Cheung 
PR-URL: https://github.com/nodejs/node/pull/49491
Refs: https://github.com/v8/v8/commit/b60a03df4cebafb4c92ee644d11617ad73889e5e
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49491
Refs: https://github.com/v8/v8/commit/b60a03df4cebafb4c92ee644d11617ad73889e5e
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 04 Sep 2023 21:11:57 GMT
   ✔  Approvals: 1
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49491#pullrequestreview-1618824001
   ✘  This PR needs to wait 9 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-09-08T11:06:13Z: https://ci.nodejs.org/job/node-test-pull-request/53814/
- Querying data for job/node-test-pull-request/53814/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6145737064

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 11, 2023
joyeecheung commented Sep 11, 2023
View reviewed changes
Comment thread common.gypi Outdated
deps: V8: cherry-pick b60a03df4ceb
f4bc4f2 
Original commit message:

    [api] mark v8::Script and v8::UnboundScript as v8::Data

    v8::UnboundModuleScript and v8::Module are already v8::Data.
    Mark v8::Script and v8::UnboundScript as v8::Data so that they
    can be used in other V8 APIs that takes v8::Data.

    Refs: nodejs#48510

    Bug: v8:14120
    Change-Id: I2dd5648528c1b0030292872441758d4fb2cfcc1c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4827307
    Reviewed-by: Camillo Bruni <cbruni@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#89727}

Refs: v8/v8@b60a03d
joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 11, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 11, 2023

nodejs-github-bot commented Sep 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53888/

nodejs-github-bot commented Sep 11, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5555/

nodejs-github-bot commented Sep 11, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5555/

nodejs-github-bot commented Sep 11, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5555/

joyeecheung added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 12, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 12, 2023
nodejs-github-bot merged commit 668437c into nodejs:main Sep 12, 2023

nodejs-github-bot commented Sep 12, 2023

Copy link
Copy Markdown
Collaborator

Landed in 668437c

joyeecheung mentioned this pull request Sep 12, 2023
Closed
joyeecheung mentioned this pull request Sep 15, 2023
Closed
joyeecheung added a commit to joyeecheung/node that referenced this pull request Sep 26, 2023
deps: V8: cherry-pick b60a03df4ceb
bce8b0b 
Original commit message:

    [api] mark v8::Script and v8::UnboundScript as v8::Data

    v8::UnboundModuleScript and v8::Module are already v8::Data.
    Mark v8::Script and v8::UnboundScript as v8::Data so that they
    can be used in other V8 APIs that takes v8::Data.

    Refs: nodejs#48510

    Bug: v8:14120
    Change-Id: I2dd5648528c1b0030292872441758d4fb2cfcc1c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4827307
    Reviewed-by: Camillo Bruni <cbruni@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#89727}

Refs: v8/v8@b60a03d
PR-URL: nodejs#49491
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
joyeecheung mentioned this pull request Sep 26, 2023
Closed
RafaelGSS mentioned this pull request Oct 9, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anonrig anonrig approved these changes
+2 more reviewers
Linkgoron Linkgoron approved these changes
aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL