esm: jsdoc for modules code - #49523
Merged
nodejs-github-bot merged 15 commits intoSep 19, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
anonrig
reviewed
Sep 7, 2023
Comment thread
.eslintrc.js
Outdated
Copy link
Copy Markdown
Contributor
|
Adding https://github.com/nodejs/node/labels/backport-requested-v20.x because we probably don't want to land the lint rule there, it's likely going to cause conflicts. |
Sorry, something went wrong.
GeoffreyBooth
force-pushed
the
tidy-modules-code
branch
from
1c78689 to
aea0d64
Compare
September 10, 2023 05:23
GeoffreyBooth
commented
Sep 10, 2023
Comment thread
lib/internal/dns/promises.js
Outdated
JakobJingleheimer
force-pushed
the
tidy-modules-code
branch
from
9504d58 to
2f48a32
Compare
September 10, 2023 15:37
GeoffreyBooth
force-pushed
the
tidy-modules-code
branch
from
c8be6a5 to
9fe5fde
Compare
September 14, 2023 06:30
GeoffreyBooth
marked this pull request as ready for review
September 14, 2023 06:31
Copy link
Copy Markdown
Member
Author
|
Okay, all the functions have JSDoc comments. If the folks who have been around for a long time can kindly review this, I and GitHub Copilot would appreciate some double-checking of our work from the original authors of the modules code. |
Sorry, something went wrong.
aduh95
reviewed
Sep 14, 2023
Comment thread
lib/internal/modules/esm/create_dynamic_module.js
Outdated
Comment thread
lib/internal/modules/esm/create_dynamic_module.js
Outdated
Comment thread
lib/internal/modules/esm/fetch_module.js
Outdated
Comment thread
lib/internal/modules/esm/fetch_module.js
Outdated
Comment thread
lib/internal/modules/esm/fetch_module.js
Outdated
Comment thread
lib/internal/modules/esm/formats.js
Outdated
Comment thread
lib/internal/modules/esm/loader.js
Outdated
GeoffreyBooth
force-pushed
the
tidy-modules-code
branch
from
3e7fdb4 to
e564349
Compare
September 14, 2023 22:02
GeoffreyBooth
force-pushed
the
tidy-modules-code
branch
from
e564349 to
9cd82da
Compare
September 15, 2023 19:32
jasnell
approved these changes
Sep 16, 2023
GeoffreyBooth
force-pushed
the
tidy-modules-code
branch
from
ca693a7 to
418feec
Compare
September 17, 2023 05:02
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
GeoffreyBooth
force-pushed
the
tidy-modules-code
branch
from
9bd2493 to
81baff7
Compare
September 18, 2023 03:24
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Sep 20, 2023
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Oct 14, 2023
PR-URL: nodejs#49523 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #49523 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Nov 11, 2023
PR-URL: nodejs#49523 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Dec 8, 2023
codebytere
added a commit
to electron/electron
that referenced
this pull request
Dec 11, 2023
* chore: bump node in DEPS to v20.10.0 * chore: update feat_initialize_asar_support.patch no code changes; patch just needed an update due to nearby upstream changes Xref: nodejs/node#49986 * chore: update pass_all_globals_through_require.patch no manual changes; patch applied with fuzz Xref: nodejs/node#49657 * chore: update refactor_allow_embedder_overriding_of_internal_fs_calls Xref: nodejs/node#49912 no code changes; patch just needed an update due to nearby upstream changes * chore: update chore_allow_the_node_entrypoint_to_be_a_builtin_module.patch Xref: nodejs/node#49986 minor manual changes needed to sync with upstream change * update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch Xref: nodejs/node#50096 Xref: nodejs/node#50314 in lib/internal/modules/esm/load.js, update the code that checks for `format === 'electron'`. I'd like 👀 on this Xref: nodejs/node#49657 add braces in lib/internal/modules/esm/translators.js to sync with upstream * fix: lazyload fs in esm loaders to apply asar patches * nodejs/node#50127 * nodejs/node#50096 * esm: jsdoc for modules code nodejs/node#49523 * test: set test-cli-node-options as flaky nodejs/node#50296 * deps: update c-ares to 1.20.1 nodejs/node#50082 * esm: bypass CommonJS loader under --default-type=module nodejs/node#49986 * deps: update uvwasi to 0.0.19 nodejs/node#49908 * lib,test: do not hardcode Buffer.kMaxLength nodejs/node#49876 * crypto: account for disabled SharedArrayBuffer nodejs/node#50034 * test: fix edge snapshot stack traces nodejs/node#49659 * src: generate snapshot with --predictable nodejs/node#48749 * chore: fixup patch indices * fs: throw errors from sync branches instead of separate implementations nodejs/node#49913 * crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey nodejs/node#50234 * esm: detect ESM syntax in ambiguous JavaScrip nodejs/node#50096 * fixup! test: fix edge snapshot stack traces * esm: unflag extensionless ES module JavaScript and Wasm in module scope nodejs/node#49974 * [tagged-ptr] Arrowify objects https://chromium-review.googlesource.com/c/v8/v8/+/4705331 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49523 Backport-PR-URL: nodejs/node#50669 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49523 Backport-PR-URL: nodejs/node#50669 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds JSDoc annotations for all the files in lib/internal/modules/* as well as a lint rule to enforce keeping that code annotated.