perf_hooks: fix for redundant validation check for number - #49547
Closed
pluris wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
deokjinkim
reviewed
Sep 8, 2023
Comment thread
lib/internal/histogram.js
| validateNumber(percentile, 'percentile'); | ||
| if (NumberIsNaN(percentile) || percentile <= 0 || percentile > 100) | ||
| throw new ERR_OUT_OF_RANGE('percentile', '> 0 && <= 100', percentile); | ||
| validateNumber(percentile, 'percentile', 1, 100); |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I tried this approach before, but all the numbers between 0 and 1 are not allowed any more with this PR.
This(#45772 (comment)) is previous discussion.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
@deokjinkim Thank you for explaining the history. I'll close it.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has been modified so that Type and range can be checked only with validateNumber.
Below is a modified reference to a similar case.
Refs: #45770