test: show more info on failure in test-cli-syntax-require.js - #49561
Merged
nodejs-github-bot merged 2 commits intoSep 12, 2023
Merged
test: show more info on failure in test-cli-syntax-require.js#49561nodejs-github-bot merged 2 commits into
nodejs-github-bot merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Use spawnSyncAndExit() to show more info when the tes fails.
Copy link
Copy Markdown
Member
Author
|
Background: I saw this in the CI https://ci.nodejs.org/job/node-test-commit-aix/47916/nodes=aix72-ppc64/console and there's really nothing in the logs that one can use to tell what caused the failure... |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
On a side note - not sure why this needs to be in sequential. It looks fine to be placed in parallel.. |
Sorry, something went wrong.
MoLow
approved these changes
Sep 9, 2023
MoLow
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM but lint is failing
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
ruyadorno
approved these changes
Sep 11, 2023
RafaelGSS
approved these changes
Sep 11, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
19 tasks
Linkgoron
approved these changes
Sep 12, 2023
This was referenced Sep 16, 2023
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
Use spawnSyncAndExit() to show more info when the tes fails. PR-URL: #49561 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use spawnSyncAndExit() to show more info when the tes fails.