FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

typings: fix missing property in `ExportedHooks` by aduh95 · Pull Request #49567 · nodejs/node · GitHub

/ node Public

typings: fix missing property in ExportedHooks - #49567

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:exported-hooks-initialize
Sep 9, 2023
ConversationCommits (1)ChecksFiles changed
Merged

typings: fix missing property in ExportedHooks#49567
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:exported-hooks-initialize

Conversation

aduh95 commented Sep 8, 2023

Copy link
Copy Markdown
Contributor

No description provided.

aduh95 added fast-track PRs that do not need to wait for 48 hours to land. typings labels Sep 8, 2023

nodejs-github-bot commented Sep 8, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

github-actions Bot commented Sep 8, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Sep 8, 2023
GeoffreyBooth added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Sep 9, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 9, 2023

nodejs-github-bot commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49567
✔  Done loading data for nodejs/node/pull/49567
----------------------------------- PR info ------------------------------------
Title      typings: fix missing property in `ExportedHooks` (#49567)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:exported-hooks-initialize -> nodejs:main
Labels     esm, fast-track, needs-ci, typings, commit-queue-squash
Commits    1
 - typings: fix missing property in `ExportedHooks`
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/49567
Reviewed-By: Geoffrey Booth 
Reviewed-By: Jacob Smith 
Reviewed-By: Mohammed Keyvanzadeh 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49567
Reviewed-By: Geoffrey Booth 
Reviewed-By: Jacob Smith 
Reviewed-By: Mohammed Keyvanzadeh 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 08 Sep 2023 21:20:31 GMT
   ✔  Approvals: 3
   ✔  - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618318659
   ✔  - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618614867
   ✔  - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618632222
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6131683938

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 9, 2023
GeoffreyBooth added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 9, 2023
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 9, 2023

nodejs-github-bot commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49567
✔  Done loading data for nodejs/node/pull/49567
----------------------------------- PR info ------------------------------------
Title      typings: fix missing property in `ExportedHooks` (#49567)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:exported-hooks-initialize -> nodejs:main
Labels     esm, fast-track, typings, commit-queue-squash
Commits    1
 - typings: fix missing property in `ExportedHooks`
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/49567
Reviewed-By: Geoffrey Booth 
Reviewed-By: Jacob Smith 
Reviewed-By: Mohammed Keyvanzadeh 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49567
Reviewed-By: Geoffrey Booth 
Reviewed-By: Jacob Smith 
Reviewed-By: Mohammed Keyvanzadeh 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 08 Sep 2023 21:20:31 GMT
   ✔  Approvals: 3
   ✔  - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618318659
   ✔  - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618614867
   ✔  - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618632222
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6131826631

GeoffreyBooth added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2023

nodejs-github-bot commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53843/

GeoffreyBooth added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 9, 2023
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 9, 2023

nodejs-github-bot commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49567
✔  Done loading data for nodejs/node/pull/49567
----------------------------------- PR info ------------------------------------
Title      typings: fix missing property in `ExportedHooks` (#49567)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:exported-hooks-initialize -> nodejs:main
Labels     esm, fast-track, typings, commit-queue-squash
Commits    1
 - typings: fix missing property in `ExportedHooks`
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/49567
Reviewed-By: Geoffrey Booth 
Reviewed-By: Jacob Smith 
Reviewed-By: Mohammed Keyvanzadeh 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49567
Reviewed-By: Geoffrey Booth 
Reviewed-By: Jacob Smith 
Reviewed-By: Mohammed Keyvanzadeh 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 08 Sep 2023 21:20:31 GMT
   ✔  Approvals: 3
   ✔  - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618318659
   ✔  - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618614867
   ✔  - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618632222
   ℹ  This PR is being fast-tracked
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-09-09T17:55:08Z: https://ci.nodejs.org/job/node-test-pull-request/53843/
- Querying data for job/node-test-pull-request/53843/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6132755646

nodejs-github-bot commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53844/

MoLow added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Sep 9, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 9, 2023
nodejs-github-bot merged commit 5bb0cb2 into nodejs:main Sep 9, 2023

nodejs-github-bot commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator

Landed in 5bb0cb2

aduh95 deleted the exported-hooks-initialize branch September 9, 2023 22:07
This was referenced Sep 10, 2023
Open
Open
Open
joyeecheung mentioned this pull request Sep 12, 2023
Closed
This was referenced Sep 13, 2023
Open
Open
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
typings: fix missing property in ExportedHooks
ac06607 
PR-URL: #49567
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This was referenced Sep 28, 2023
Closed
Merged
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
typings: fix missing property in ExportedHooks
71c4ae3 
PR-URL: nodejs#49567
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos mentioned this pull request Nov 11, 2023
Closed
targos pushed a commit that referenced this pull request Nov 23, 2023
typings: fix missing property in ExportedHooks
9456094 
PR-URL: #49567
Backport-PR-URL: #50669
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
typings: fix missing property in ExportedHooks
5622da9 
PR-URL: nodejs/node#49567
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
typings: fix missing property in ExportedHooks
1353fe7 
PR-URL: nodejs/node#49567
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

GeoffreyBooth GeoffreyBooth approved these changes
JakobJingleheimer JakobJingleheimer approved these changes
UlisesGascon UlisesGascon approved these changes
MoLow MoLow approved these changes
+1 more reviewer
VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land. typings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL