[v18.x backport] Backport a couple of PRs - #49618
Closed
atlowChemi wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
14 tasks
ruyadorno
force-pushed
the
v18.x-staging
branch
from
b809016 to
ef85828
Compare
September 13, 2023 01:11
15 tasks
atlowChemi
force-pushed
the
backport-47775-and-48521-to-18
branch
from
9cde48f to
bdd8165
Compare
September 14, 2023 05:40
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Sep 15, 2023
32 tasks
ruyadorno
force-pushed
the
v18.x-staging
branch
from
ef85828 to
490fc00
Compare
September 17, 2023 02:48
33 tasks
Signed-off-by: Erick Wendel <erick.workspace@gmail.com> PR-URL: nodejs#47775 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
PR-URL: nodejs#48521 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
atlowChemi
force-pushed
the
backport-47775-and-48521-to-18
branch
from
bdd8165 to
e2e8ce6
Compare
September 18, 2023 05:46
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/54027/ |
Sorry, something went wrong.
This was referenced Sep 19, 2023
22 tasks
Copy link
Copy Markdown
Member
|
Hi @atlowChemi I did a citgm run for this PR and there are a few issues popping up: ncu-ci citgm 3298 3300 -------------------------------------------------------------------------------- [1/1] Running CITGM: 3298 -------------------------------------------------------------------------------- ✔ Summary data downloaded ✔ Results data downloaded ✔ Summary data downloaded ✔ Results data downloaded ----------------------------------- Summary ------------------------------------ Result FAILURE URL https://ci.nodejs.org/job/citgm-smoker/3298/ Source https://api.github.com/repos/nodejs/node/git/refs/heads/v18.x Commit [779043d5297f] Working on v18.18.1 Date 2023-09-18 17:21:18 -0400 Author Ruy Adorno <ruyadorno@google.com> ----------------------------------- Summary ------------------------------------ Result FAILURE URL https://ci.nodejs.org/job/citgm-smoker/3300/ Source https://github.com/nodejs/node/pull/49618/ Commit [e2e8ce639ca1] fs: use kResistStopPropagation Date 2023-09-18 08:34:30 +0300 Author Chemi Atlow <chemi@atlow.co.il> ----------------------------------- Results ------------------------------------ FAILURE: 8 failures in 3300 not present in 3298 ┌───────────────┬─────────────────────────┬─────────────────────────┐ │ (index) │ 0 │ 1 │ ├───────────────┼─────────────────────────┼─────────────────────────┤ │ win-vs2019 │ 'pino-v8.15.4' │ │ │ ubuntu1804-64 │ 'torrent-stream-v1.2.1' │ │ │ rhel8-x64 │ 'multer-v1.4.5-lts.1' │ 'torrent-stream-v1.2.1' │ │ rhel8-s390x │ 'torrent-stream-v1.2.1' │ │ │ aix72-ppc64 │ 'torrent-stream-v1.2.1' │ │ │ rhel8-ppc64le │ 'pino-v8.15.4' │ 'torrent-stream-v1.2.1' │ │ osx1015 │ │ │ └───────────────┴─────────────────────────┴─────────────────────────┘ While it does seem like it may be a timeout problem that might be caused by the library / tests errors, I would appreciate if you can take some time to look at the results for torrent-stream@1.2.1 on https://ci.nodejs.org/job/citgm-smoker/3300/ pino@8.15.x and multer@1.4.5 issues are already documented so you don't need to worry about these. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@ruyadorno I do not think this is related (though I do not have any cutting proof 😕) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Signed-off-by: Erick Wendel <erick.workspace@gmail.com> PR-URL: nodejs/node#47775 Backport-PR-URL: nodejs/node#49618 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#48521 Backport-PR-URL: nodejs/node#49618 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Signed-off-by: Erick Wendel <erick.workspace@gmail.com> PR-URL: nodejs/node#47775 Backport-PR-URL: nodejs/node#49618 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#48521 Backport-PR-URL: nodejs/node#49618 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #47775 and #48521 (which was blocked by #47775)