FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: mark test-runner-watch-mode as flaky by joyeecheung · Pull Request #49627 · nodejs/node · GitHub

/ node Public

test: mark test-runner-watch-mode as flaky - #49627

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:test-runner-flake
Sep 14, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: mark test-runner-watch-mode as flaky#49627
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:test-runner-flake

Conversation

joyeecheung commented Sep 12, 2023

Copy link
Copy Markdown
Member

Refs: #49605

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2023
nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 12, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2023

nodejs-github-bot commented Sep 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53913/

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2023

joyeecheung commented Sep 12, 2023

Copy link
Copy Markdown
Member Author

Actually it's flaky on both Linux and Windows. nodejs/reliability#663 Added windows to the condition.

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2023

nodejs-github-bot commented Sep 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53914/

github-actions Bot mentioned this pull request Sep 13, 2023
Open
14 tasks

nodejs-github-bot commented Sep 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53923/

nodejs-github-bot commented Sep 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53926/

LiviaMedeiros added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 13, 2023
github-actions Bot mentioned this pull request Sep 14, 2023
Open
15 tasks
debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 14, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 14, 2023
nodejs-github-bot merged commit b289c6d into nodejs:main Sep 14, 2023

nodejs-github-bot commented Sep 14, 2023

Copy link
Copy Markdown
Collaborator

Landed in b289c6d

This was referenced Sep 15, 2023
Open
Open
Open
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
test: mark test-runner-watch-mode as flaky
ab3afb3 
PR-URL: #49627
Refs: #49605
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
This was referenced Sep 28, 2023
Closed
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
test: mark test-runner-watch-mode as flaky
5df2352 
PR-URL: #49627
Refs: #49605
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test: mark test-runner-watch-mode as flaky
6305d66 
PR-URL: nodejs/node#49627
Refs: nodejs/node#49605
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test: mark test-runner-watch-mode as flaky
2201bcf 
PR-URL: nodejs/node#49627
Refs: nodejs/node#49605
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

watilde watilde approved these changes
anonrig anonrig approved these changes
LiviaMedeiros LiviaMedeiros approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL