esm: update loaders warning - #49633
Merged
nodejs-github-bot merged 7 commits intoSep 19, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
JakobJingleheimer
approved these changes
Sep 13, 2023
Copy link
Copy Markdown
Contributor
|
Can we keep the warning for use of --loader? This one is not RC IIUC, so it should still have a warning. |
Sorry, something went wrong.
benjamingr
approved these changes
Sep 13, 2023
Copy link
Copy Markdown
Member
Author
It turns out the previous warning was only for --loader / --experimental-loader, not for register. So people already using the new --import / register flow aren’t seeing any warnings. I updated this to change the warning to push people in that direction. @aduh95 ./node --loader ./test/fixtures/es-module-loaders/never-settling-resolve-step/loader.mjs \ ./test/fixtures/es-module-loaders/never-settling-resolve-step/race.cjs (node:49878) ExperimentalWarning: `--experimental-loader` may be removed in the future; instead use `--import` to reference a file that calls `register()` |
Sorry, something went wrong.
GeoffreyBooth
force-pushed
the
remove-loaders-warning
branch
from
601890e to
70b1a64
Compare
September 14, 2023 00:01
aduh95
reviewed
Sep 14, 2023
Comment thread
test/es-module/test-esm-experimental-warnings.mjs
Outdated
Comment thread
lib/internal/modules/esm/loader.js
Outdated
aduh95
reviewed
Sep 14, 2023
Comment thread
test/es-module/test-esm-experimental-warnings.mjs
Outdated
jasnell
approved these changes
Sep 16, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
reviewed
Sep 16, 2023
Comment thread
lib/internal/modules/esm/loader.js
Outdated
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
force-pushed
the
remove-loaders-warning
branch
from
24f23b5 to
45d517d
Compare
September 16, 2023 21:28
32 tasks
GeoffreyBooth
commented
Sep 17, 2023
Comment thread
lib/internal/modules/esm/loader.js
33 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/49633 ✔ Done loading data for nodejs/node/pull/49633 ----------------------------------- PR info ------------------------------------ Title esm: update loaders warning (#49633) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch GeoffreyBooth:remove-loaders-warning -> nodejs:main Labels experimental, esm, author ready, needs-ci, loaders, commit-queue-squash Commits 7 - esm: update loaders warning - Change warning to be specific to --experimental-loader - Update test/es-module/test-esm-experimental-warnings.mjs - Update test/es-module/test-esm-experimental-warnings.mjs - Improve warning - lint - `readableURIEncode` Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/49633 Reviewed-By: Jacob Smith Reviewed-By: Benjamin Gruenbaum Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49633 Reviewed-By: Jacob Smith Reviewed-By: Benjamin Gruenbaum Reviewed-By: James M Snell -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - esm: update loaders warning ⚠ - Change warning to be specific to --experimental-loader ⚠ - Update test/es-module/test-esm-experimental-warnings.mjs ⚠ - Update test/es-module/test-esm-experimental-warnings.mjs ⚠ - Improve warning ⚠ - lint ⚠ - `readableURIEncode` ℹ This PR was created on Wed, 13 Sep 2023 04:59:11 GMT ✔ Approvals: 3 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/49633#pullrequestreview-1623900278 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/49633#pullrequestreview-1625510070 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/49633#pullrequestreview-1629979006 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-09-18T16:05:36Z: https://ci.nodejs.org/job/node-test-pull-request/54041/ - Querying data for job/node-test-pull-request/54041/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6225715618 |
Sorry, something went wrong.
32 tasks
guybedford
reviewed
Sep 19, 2023
guybedford
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nice to see the progress here. I'd love to see a short flag for --import at some point as well.
Sorry, something went wrong.
Comment thread
lib/internal/modules/esm/loader.js
guybedford
approved these changes
Sep 19, 2023
27 tasks
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
PR-URL: #49633 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Nov 11, 2023
PR-URL: nodejs#49633 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49633 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49633 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up #49597, this PR edits the warning when --experimental-loader / --loader is used to tell people to use --import / register() instead, which has no warning. The separate warning about globalPreload remains.