FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test_runner: catch reporter errors by MoLow · Pull Request #49646 · nodejs/node · GitHub

/ node Public

test_runner: catch reporter errors - #49646

Closed
MoLow wants to merge 3 commits into
nodejs:mainfrom
MoLow:print-reporter-errors
ConversationCommits (3)ChecksFiles changed
Closed

test_runner: catch reporter errors#49646
MoLow wants to merge 3 commits into
nodejs:mainfrom
MoLow:print-reporter-errors

Conversation

MoLow commented Sep 14, 2023

Copy link
Copy Markdown
Member

Fixes: #48937

nodejs-github-bot commented Sep 14, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Sep 14, 2023
ljharb requested changes Sep 14, 2023
View reviewed changes
Comment thread lib/internal/test_runner/utils.js Outdated
ljharb approved these changes Sep 14, 2023
View reviewed changes

ljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

would be good to have a test of something that does process.exitCode = 42 or whatever, and then throws, and asserts that the exitCode remains 42 afterwards

MoLow added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 14, 2023
atlowChemi approved these changes Sep 14, 2023
View reviewed changes
Comment thread lib/internal/test_runner/utils.js Outdated
cjihrig reviewed Sep 14, 2023
View reviewed changes
Comment thread lib/internal/test_runner/utils.js Outdated
benjamingr reviewed Sep 14, 2023
View reviewed changes
Comment thread lib/internal/test_runner/utils.js Outdated
benjamingr requested changes Sep 14, 2023
View reviewed changes

benjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I was convinced think @cjihrig is right and we should also deal with the case the error is async given this is the test runner.

MoLow force-pushed the print-reporter-errors branch from 81853a5 to c40d76d Compare September 21, 2023 06:17
atlowChemi reviewed Sep 21, 2023
View reviewed changes
Comment thread lib/internal/test_runner/harness.js Outdated
MoLow removed the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 21, 2023
MoLow force-pushed the print-reporter-errors branch from c40d76d to 38aed2c Compare September 21, 2023 07:00
MoLow added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 21, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2023

nodejs-github-bot commented Sep 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54105/

MoLow added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 21, 2023
cjihrig approved these changes Sep 21, 2023
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM once the CI passes.

Comment thread test/fixtures/test-runner/custom_reporters/throwing-async.js Outdated
Comment thread test/fixtures/test-runner/custom_reporters/throwing.js Outdated
Apply suggestions from code review
aebf089 
Co-authored-by: Colin Ihrig <cjihrig@gmail.com>
MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2023

nodejs-github-bot commented Sep 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54137/

MoLow added a commit to MoLow/node that referenced this pull request Sep 21, 2023
test_runner: catch reporter errors
a4c7f81 
PR-URL: nodejs#49646
Fixes: nodejs#48937
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MoLow commented Sep 21, 2023

Copy link
Copy Markdown
Member Author

Landed in a4c7f81

MoLow closed this Sep 21, 2023
MoLow deleted the print-reporter-errors branch September 21, 2023 20:26
This was referenced Sep 22, 2023
Open
Open
Open

ruyadorno commented Sep 28, 2023

Copy link
Copy Markdown
Member

This commit does not land cleanly on v20.x-staging and will need manual backport in case we want it in v20.

MoLow mentioned this pull request Sep 28, 2023
Closed
MoLow added a commit to MoLow/node that referenced this pull request Sep 28, 2023
test_runner: catch reporter errors
0e27a7a 
PR-URL: nodejs#49646
Fixes: nodejs#48937
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
RafaelGSS mentioned this pull request Oct 9, 2023
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
test_runner: catch reporter errors
27558c4 
PR-URL: #49646
Fixes: #48937
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
test_runner: catch reporter errors
103c4a0 
PR-URL: #49646
Fixes: #48937
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos mentioned this pull request Nov 28, 2023
Merged
juanarbol mentioned this pull request Dec 6, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test_runner: catch reporter errors
9e54ca0 
PR-URL: nodejs/node#49646
Fixes: nodejs/node#48937
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test_runner: catch reporter errors
5f38e70 
PR-URL: nodejs/node#49646
Fixes: nodejs/node#48937
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

atlowChemi atlowChemi approved these changes
benjamingr benjamingr approved these changes
cjihrig cjihrig approved these changes
ljharb Awaiting requested review from ljharb

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Throwing an exception on test reporters silently error the test runner

8 participants

Back | FazBrowse Home | New Git URL