src: move const variable in node_file.h to node_file.cc - #49688
Merged
nodejs-github-bot merged 1 commit intoSep 29, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
anonrig
approved these changes
Sep 17, 2023
pluris
force-pushed
the
fix/const_variable
branch
from
2c554b7 to
5893137
Compare
September 17, 2023 14:28
anonrig
approved these changes
Sep 17, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Sep 18, 2023
H4ad
approved these changes
Sep 20, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
22 tasks
debadree25
pushed a commit
to debadree25/node
that referenced
this pull request
Apr 15, 2024
PR-URL: nodejs#49688 Refs: nodejs#48325 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After checking the comments in the reference, it seems that there is no need to define a 'const' variable in the header.
It seems efficient to handle this by defining it as constexpr in the source file so that it can be evaluated at compile time. For this purpose, it would be better to change it to std::string_view rather than handling it as std::string.
Refs: #48325