FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

esm: fix return type of `import.meta.resolve` by aduh95 · Pull Request #49698 · nodejs/node · GitHub

/ node Public

esm: fix return type of import.meta.resolve - #49698

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:import-meta-resolve
Sep 20, 2023
ConversationCommits (2)ChecksFiles changed
Merged

esm: fix return type of import.meta.resolve#49698
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:import-meta-resolve

Conversation

aduh95 commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

Fixes: #49695

nodejs-github-bot commented Sep 18, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Sep 18, 2023
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 18, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 18, 2023

nodejs-github-bot commented Sep 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54039/

guybedford requested changes Sep 18, 2023
View reviewed changes
Comment thread lib/internal/modules/esm/initialize_import_meta.js Outdated
github-actions Bot mentioned this pull request Sep 19, 2023
Open
32 tasks

nodejs-github-bot commented Sep 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54052/

nodejs-github-bot commented Sep 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54061/

GeoffreyBooth added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Sep 19, 2023
GeoffreyBooth mentioned this pull request Sep 19, 2023
Closed
github-actions Bot mentioned this pull request Sep 20, 2023
Open
27 tasks
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2023
nodejs-github-bot merged commit 20b996d into nodejs:main Sep 20, 2023

nodejs-github-bot commented Sep 20, 2023

Copy link
Copy Markdown
Collaborator

Landed in 20b996d

This was referenced Sep 21, 2023
Open
Open
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
esm: fix return type of import.meta.resolve
8a6f5fb 
PR-URL: #49698
Fixes: #49695
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
This was referenced Sep 28, 2023
Closed
Merged
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
esm: fix return type of import.meta.resolve
44b345c 
PR-URL: nodejs#49698
Fixes: nodejs#49695
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
targos mentioned this pull request Nov 11, 2023
Closed
targos pushed a commit that referenced this pull request Nov 23, 2023
esm: fix return type of import.meta.resolve
46d730a 
PR-URL: #49698
Backport-PR-URL: #50669
Fixes: #49695
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
esm: fix return type of import.meta.resolve
b04a64e 
PR-URL: nodejs/node#49698
Backport-PR-URL: nodejs/node#50669
Fixes: nodejs/node#49695
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
esm: fix return type of import.meta.resolve
32dda85 
PR-URL: nodejs/node#49698
Backport-PR-URL: nodejs/node#50669
Fixes: nodejs/node#49695
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Josh-Cena mentioned this pull request Aug 6, 2024
Closed
skyclouds2001 mentioned this pull request Nov 10, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

GeoffreyBooth GeoffreyBooth approved these changes
guybedford guybedford approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

import.meta.resolve(…) is documented to return a string, but returns a URL object

5 participants

Back | FazBrowse Home | New Git URL