doc: add missed inspect with numericSeparator to example - #49717
Merged
nodejs-github-bot merged 1 commit intoSep 21, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
In exmple of `util.inspect` with numericSeparator option, calling `util.inspect` is missed. So actual result is different from expected result.
LiviaMedeiros
approved these changes
Sep 19, 2023
MoLow
approved these changes
Sep 19, 2023
aymen94
approved these changes
Sep 20, 2023
lpinca
approved these changes
Sep 20, 2023
trivikr
approved these changes
Sep 20, 2023
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
In exmple of `util.inspect` with numericSeparator option, calling `util.inspect` is missed. So actual result is different from expected result. PR-URL: #49717 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In exmple of util.inspect with numericSeparator option, calling util.inspect is missed. So actual result is different from expected result.
Expected result:
Actual result: