deps: remove pthread-fixes.c from uv.gyp - #49744
Merged
nodejs-github-bot merged 1 commit intoSep 23, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The file was removed in the latest libuv upgrade. Remove it from the build recipe as well. Fixes: nodejs#49739
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Closed
RaisinTen
approved these changes
Sep 21, 2023
debadree25
approved these changes
Sep 21, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
cjihrig
approved these changes
Sep 21, 2023
richardlau
approved these changes
Sep 21, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
gengjiawen
approved these changes
Sep 21, 2023
tniessen
approved these changes
Sep 21, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Sep 21, 2023
santigimeno
approved these changes
Sep 21, 2023
santigimeno
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
My bad. Thanks for fixing this
Sorry, something went wrong.
This was referenced Sep 22, 2023
20 tasks
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
The file was removed in the latest libuv upgrade. Remove it from the build recipe as well. Fixes: #49739 PR-URL: #49744 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file was removed in the latest libuv upgrade. Remove it from the build recipe as well.
Fixes: #49739