FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: use mustSucceed instead of mustCall by SiddharthDevulapalli · Pull Request #49788 · nodejs/node · GitHub

/ node Public

test: use mustSucceed instead of mustCall - #49788

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
SiddharthDevulapalli:siddharth-ghc
Sep 25, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: use mustSucceed instead of mustCall#49788
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
SiddharthDevulapalli:siddharth-ghc

Conversation

SiddharthDevulapalli commented Sep 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request is for the Issue provided in the Open Source Day of GHC
Issue guideline - "Replace mustCall((err, data) ...) with mustSucceed((data) ...) in test-trace-events-bootstrap.js"

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 22, 2023
tniessen reviewed Sep 22, 2023
View reviewed changes

tniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Awesome, thank you @SiddharthDevulapalli. Could you please amend the commit message as described here to comply with our guidelines? The commit message should begin with test:. For example, test: use mustSucceed instead of mustCall would work.

tniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 22, 2023
SiddharthDevulapalli changed the title Updated mustCall to mustSucceed test: use mustSucceed instead of mustCall Sep 22, 2023

SiddharthDevulapalli commented Sep 22, 2023

Copy link
Copy Markdown
Contributor Author

Awesome, thank you @SiddharthDevulapalli. Could you please amend the commit message as described here to comply with our guidelines? The commit message should begin with test:. For example, test: use mustSucceed instead of mustCall would work.

SiddharthDevulapalli commented Sep 22, 2023

Copy link
Copy Markdown
Contributor Author

Hi Tobias, I updated the commit title, let me know if this works.

tniessen commented Sep 22, 2023

Copy link
Copy Markdown
Member

@SiddharthDevulapalli Unfortunately, updating the PR title is not sufficient. You need to force-push to the same branch with an amended commit message as described in my previous comment.

SiddharthDevulapalli commented Sep 22, 2023

Copy link
Copy Markdown
Contributor Author

@tniessen I changed the commit message and force pushed, good to go now

tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023

This comment was marked as outdated.

Sign in to view
github-actions Bot mentioned this pull request Sep 24, 2023
Open
20 tasks

nodejs-github-bot commented Sep 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54192/

tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 25, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 25, 2023
nodejs-github-bot merged commit 1716769 into nodejs:main Sep 25, 2023

nodejs-github-bot commented Sep 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in 1716769

tniessen commented Sep 25, 2023

Copy link
Copy Markdown
Member

Congratulations on becoming a Node.js contributor @SiddharthDevulapalli!

SiddharthDevulapalli commented Sep 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thank you @tniessen

ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
test: use mustSucceed instead of mustCall
eded29c 
PR-URL: #49788
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
ruyadorno mentioned this pull request Sep 28, 2023
Closed
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
test: use mustSucceed instead of mustCall
5ad0042 
PR-URL: #49788
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
ruyadorno mentioned this pull request Sep 28, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
tniessen tniessen approved these changes
trivikr trivikr approved these changes

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL