FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: use destructuring in test-path-parse-format by gibbyfree · Pull Request #49790 · nodejs/node · GitHub

/ node Public

test: use destructuring in test-path-parse-format - #49790

Merged
aduh95 merged 2 commits into
nodejs:mainfrom
gibbyfree:destructure
May 12, 2024
ConversationCommits (2)ChecksFiles changed
Merged

test: use destructuring in test-path-parse-format#49790
aduh95 merged 2 commits into
nodejs:mainfrom
gibbyfree:destructure

Conversation

gibbyfree commented Sep 22, 2023

Copy link
Copy Markdown
Contributor

No description provided.

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 22, 2023
tniessen approved these changes Sep 22, 2023
View reviewed changes

tniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Awesome, thank you @gibbyfree.

Comment thread test/parallel/test-path-parse-format.js Outdated
tniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 22, 2023
tniessen approved these changes Sep 22, 2023
View reviewed changes

tniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Great work, thank you!

tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023

nodejs-github-bot commented Sep 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54166/

github-actions Bot mentioned this pull request Sep 24, 2023
Open
20 tasks
joyeecheung mentioned this pull request Sep 25, 2023
Closed
lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023

nodejs-github-bot commented Sep 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54232/

This was referenced Sep 27, 2023
Open
Open
RafaelGSS added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 7, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2023

nodejs-github-bot commented Nov 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55477/

RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2023

nodejs-github-bot commented Nov 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55893/

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 29, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 29, 2023

nodejs-github-bot commented Dec 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56585/

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 11, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 11, 2024

nodejs-github-bot commented May 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59109/

nodejs-github-bot commented May 12, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59149/

nodejs-github-bot commented May 12, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59178/

aduh95 merged commit 33370ee into nodejs:main May 12, 2024

aduh95 commented May 12, 2024

Copy link
Copy Markdown
Contributor

Landed in 33370ee

targos pushed a commit that referenced this pull request May 12, 2024
test: use for-of instead of forEach
a589de0 
PR-URL: #49790
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos mentioned this pull request May 13, 2024
Merged
marco-ippolito mentioned this pull request Jun 17, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
test: use for-of instead of forEach
0513e07 
PR-URL: #49790
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
test: use for-of instead of forEach
c300d67 
PR-URL: nodejs#49790
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ruyadorno ruyadorno approved these changes
lpinca lpinca approved these changes
tniessen tniessen approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL