replace forEach with for loop - #49794
Closed
Ram1607 wants to merge 4 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
tniessen
reviewed
Sep 22, 2023
tniessen
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Please use for ... of instead of a traditional index-based for loop.
Sorry, something went wrong.
Trott
reviewed
Sep 22, 2023
Comment thread
test/parallel/test-dgram-socket-buffer-size.js
Outdated
Trott
reviewed
Sep 22, 2023
Comment thread
test/parallel/test-dgram-socket-buffer-size.js
Outdated
Copy link
Copy Markdown
Member
|
What is the reason for this change? I see the code-and-learn label so I guess it is from...Grace Hopper Day or something? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@Trott Yes, most occurrences of forEach predate support for for ... of. The latter allows const variables and works with non-arrays. |
Sorry, something went wrong.
lpinca
approved these changes
Nov 2, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
pushed a commit
that referenced
this pull request
Nov 2, 2023
Replace `forEach()` with `for...of` in in test-dgram-socket-buffer-size. PR-URL: #49794 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
Replace `forEach()` with `for...of` in in test-dgram-socket-buffer-size. PR-URL: #49794 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 14, 2023
Replace `forEach()` with `for...of` in in test-dgram-socket-buffer-size. PR-URL: #49794 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
Replace `forEach()` with `for...of` in in test-dgram-socket-buffer-size. PR-URL: #49794 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes will replace forEach loop to for loop