FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

perf_hooks: reduce overhead of new performance_entries by H4ad · Pull Request #49803 · nodejs/node · GitHub

/ node Public

perf_hooks: reduce overhead of new performance_entries - #49803

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
H4ad:perf/perf_hooks
Sep 27, 2023
ConversationCommits (1)ChecksFiles changed
Merged

perf_hooks: reduce overhead of new performance_entries#49803
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
H4ad:perf/perf_hooks

Conversation

H4ad commented Sep 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Continuing the work started on nodejs/performance#109

Removed two references for ReflectConstruct, the improvements for createPerformanceNodeEntry can be seen using the timerfied function:

                                                    confidence improvement accuracy (*)    (**)   (***)
perf_hooks/timerfied.js observe='function' n=100000        ***    872.44 %      ±22.56% ±30.40% ±40.36%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 1 comparisons, you can thus
expect the following amount of false-positive results:
  0.05 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.01 false positives, when considering a   1% risk acceptance (**, ***),
  0.00 false positives, when considering a 0.1% risk acceptance (***)

The createPerformanceEntry is not used, should I remove it?

/cc @nodejs/performance

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 23, 2023

H4ad commented Sep 23, 2023

Copy link
Copy Markdown
Member Author

@jasnell Do you have any reason to add ERR_ILLEGAL_CONSTRUCTOR for PerformanceEntry?

I saw the PerformanceMark without it, so maybe we could remove it from this class too, it will simplify this a lot this code.

mcollina approved these changes Sep 23, 2023
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

Uzlopak commented Sep 23, 2023

Copy link
Copy Markdown
Contributor

impressive

benjamingr approved these changes Sep 23, 2023
View reviewed changes

benjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

oh wow we were passing a new constructor each time?

This is a subtly breaking change (if someone relied on them having different constructors) but I think we never made that commitment so this is fine to me as minor/patch

gj

anonrig approved these changes Sep 23, 2023
View reviewed changes

anonrig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🚀

rluvaton reviewed Sep 23, 2023
View reviewed changes
Comment thread lib/internal/perf/performance_entry.js Outdated

H4ad commented Sep 24, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

Sorry for the force-push but I read another PR of @rluvaton, this new way is a faster (793%->872%) and cleaner way to do the same thing.

H4ad requested a review from rluvaton September 24, 2023 01:02
H4ad mentioned this pull request Sep 24, 2023
Merged
Qard approved these changes Sep 24, 2023
View reviewed changes

Qard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Out of curiosity though, with the skip throw thing in the constructor, can the perf be improved even further by putting the init behaviour directly in the constructor after the skipped throw?

H4ad commented Sep 25, 2023

Copy link
Copy Markdown
Member Author

@Qard, I need to try, but it may not change significantly as it will be essentially the same operations.

Also, I don't know if there is any spec compliance with the constructor I avoid changing the arguments of the Performance Entry, without = undefined, it breaks the webidl tests.

anonrig added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 25, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023

nodejs-github-bot commented Sep 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54218/

H4ad commented Sep 27, 2023

Copy link
Copy Markdown
Member Author

Is there something I can do about the failing checks?

nodejs-github-bot commented Sep 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54270/

Uzlopak commented Sep 27, 2023

Copy link
Copy Markdown
Contributor

@anonrig has to start them over and over again, till they are green :P

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 27, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 27, 2023
nodejs-github-bot merged commit a6ad048 into nodejs:main Sep 27, 2023

nodejs-github-bot commented Sep 27, 2023

Copy link
Copy Markdown
Collaborator

Landed in a6ad048

H4ad deleted the perf/perf_hooks branch September 27, 2023 01:52
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
perf_hooks: reduce overhead of new performance_entries
f40b5ed 
PR-URL: #49803
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
ruyadorno mentioned this pull request Sep 28, 2023
Closed
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
perf_hooks: reduce overhead of new performance_entries
b931aea 
PR-URL: #49803
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
ruyadorno mentioned this pull request Sep 28, 2023
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
perf_hooks: reduce overhead of new performance_entries
88488c3 
PR-URL: nodejs#49803
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
Qard Qard approved these changes
benjamingr benjamingr approved these changes
anonrig anonrig approved these changes
rluvaton Awaiting requested review from rluvaton

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL