test: replace forEach with for..of in test-http2-client-destroy.js - #49820
Merged
nodejs-github-bot merged 3 commits intoOct 21, 2023
Merged
test: replace forEach with for..of in test-http2-client-destroy.js#49820nodejs-github-bot merged 3 commits into
nodejs-github-bot merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
tniessen
reviewed
Sep 23, 2023
Comment thread
test/parallel/test-http2-client-destroy.js
Outdated
Copy link
Copy Markdown
Member
|
Please update all your PRs to comply with our commit message guidelines. In particular, there should be a lowercase imperative verb after the test: prefix (e.g., test: replace ... instead of test: Replaced ...). You can find instructions for updating an existing PR here. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@tniessen, I have redid all the commit messages as per your instructions. |
Sorry, something went wrong.
lpinca
reviewed
Oct 14, 2023
Comment thread
test/parallel/test-http2-client-destroy.js
Outdated
lpinca
approved these changes
Oct 14, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Oct 23, 2023
PR-URL: #49820 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #49820 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
PR-URL: #49820 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49820 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49820 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced forEach with for..of in test-http2-client-destroy.js