FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fs: improve error performance for `rmdirSync` by CanadaHonk · Pull Request #49846 · nodejs/node · GitHub

/ node Public

fs: improve error performance for rmdirSync - #49846

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
CanadaHonk:perf-rmdirsync
Nov 26, 2023
ConversationCommits (1)ChecksFiles changed
Merged

fs: improve error performance for rmdirSync#49846
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
CanadaHonk:perf-rmdirsync

Conversation

CanadaHonk commented Sep 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Results from i9/Linux/SSD:

                                                   confidence improvement accuracy (*)   (**)  (***)
fs/bench-rmdirSync.js n=10000 type='existing'                     0.54 %       ±1.35% ±1.80% ±2.34%
fs/bench-rmdirSync.js n=10000 type='non-existing'        ***     61.81 %       ±2.15% ±2.88% ±3.77%

Ref: nodejs/performance#106

Thanks to and inspiration from @anonrig 🚀

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Sep 25, 2023
anonrig reviewed Sep 25, 2023
View reviewed changes
Comment thread lib/fs.js Outdated
anonrig mentioned this pull request Sep 25, 2023
Open
anonrig reviewed Sep 25, 2023
View reviewed changes
Comment thread benchmark/fs/bench-rmdirSync.js Outdated
Comment thread benchmark/fs/bench-rmdirSync.js Outdated
Comment thread benchmark/fs/bench-rmdirSync.js Outdated

CanadaHonk commented Sep 25, 2023

Copy link
Copy Markdown
Member Author

Updated to fix all things mentioned in review, thanks!

CanadaHonk changed the title fs: improve performance for fs.rmdirSync fs: improve error performance for fs.rmdirSync Sep 25, 2023
anonrig added performance Issues and PRs related to the performance of Node.js. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. needs-benchmark-ci PR that need a benchmark CI run. labels Sep 25, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023

This comment was marked as outdated.

Sign in to view
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023

This comment was marked as outdated.

Sign in to view
CanadaHonk changed the title fs: improve error performance for fs.rmdirSync fs: improve error performance for rmdirSync Sep 25, 2023
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

CanadaHonk commented Sep 25, 2023

Copy link
Copy Markdown
Member Author

Flaky CI I think?

This comment was marked as outdated.

Sign in to view

CanadaHonk commented Sep 26, 2023

Copy link
Copy Markdown
Member Author

Flaky CI again? 😅

This comment was marked as outdated.

Sign in to view
richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2023
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2023

nodejs-github-bot commented Oct 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54829/

nodejs-github-bot commented Oct 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54897/

github-actions Bot mentioned this pull request Oct 19, 2023
Open
25 tasks

CanadaHonk commented Nov 19, 2023

Copy link
Copy Markdown
Member Author

Rebased on latest main and updated description with rebenchmark.

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2023

nodejs-github-bot commented Nov 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55773/

CanadaHonk commented Nov 21, 2023

Copy link
Copy Markdown
Member Author

Flaky CI?

nodejs-github-bot commented Nov 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55837/

nodejs-github-bot commented Nov 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55862/

H4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2023
nodejs-github-bot merged commit f11b206 into nodejs:main Nov 26, 2023

nodejs-github-bot commented Nov 26, 2023

Copy link
Copy Markdown
Collaborator

Landed in f11b206

lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
fs: improve error performance for rmdirSync
31e837c 
PR-URL: nodejs#49846
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
RafaelGSS pushed a commit that referenced this pull request Nov 27, 2023
fs: improve error performance for rmdirSync
c4f9654 
PR-URL: #49846
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
RafaelGSS mentioned this pull request Nov 28, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
fs: improve error performance for rmdirSync
483200f 
PR-URL: #49846
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
fs: improve error performance for rmdirSync
7a09209 
PR-URL: #49846
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
UlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
fs: improve error performance for rmdirSync
cb55d04 
PR-URL: #49846
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
fs: improve error performance for rmdirSync
0d59dda 
PR-URL: #49846
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
fs: improve error performance for rmdirSync
f94a24c 
PR-URL: #49846
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anonrig anonrig approved these changes
joyeecheung joyeecheung approved these changes
H4ad H4ad approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-benchmark-ci PR that need a benchmark CI run. needs-ci PRs that need a full CI run. performance Issues and PRs related to the performance of Node.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL