cc @joyeecheung

CI: https://ci.nodejs.org/job/node-test-pull-request/54214/

Why is this being fast tracked does it unblock something?

Why is this being fast tracked does it unblock something?

Pretty sure it's because it fixes repl possibly doing unwanted real FS ops for a few functions if you were to type out but not press enter (eg fs.copyFileSync(...)).

CI: https://ci.nodejs.org/job/node-test-pull-request/54217/

CI: https://ci.nodejs.org/job/node-test-pull-request/54221/

The fact that this fixes a bug does not really mean that it qualifies for fast tracking.

• The side-effect of copyFileSync is obvious.
• I guess that readFileUtf8 can modify the atime of the file
• But what are the observable side-effects of accessSync and existsSync ?

But what are the observable side-effects of accessSync and existsSync ?

There isn't but referring to @joyeecheung's message (ref: #49748 (comment)), I think it is unnecessary to run fs operations (since they're costly) on REPL.

but referring to @joyeecheung's message

I don't interpret @joyeecheung's comment (but please correct me if I'm wrong) to mean we shouldn't do it because of performance reasons. I interpret it as chown() having very real side effects.

I think it is unnecessary to run fs operations (since they're costly) on REPL.

I don't feel strongly about this, but I think this is another case where performance just isn't important. The REPL is meant to be interactive and a person typing fs.accessSync() or fs.existsSync() is very unlikely to notice any difference in performance.

Landed in 783f64b