meta: update website team with new name - #49883
Merged
Trott merged 1 commit intoSep 28, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
Sorry, something went wrong.
anonrig
approved these changes
Sep 26, 2023
aduh95
approved these changes
Sep 26, 2023
ovflowd
approved these changes
Sep 26, 2023
Copy link
Copy Markdown
Member
|
@Trott can you update the PR? The correct team here would be @nodejs/web-infra (Due to this being a more technical + infrastructure part (the API tooling)) |
Sorry, something went wrong.
MoLow
approved these changes
Sep 26, 2023
Copy link
Copy Markdown
Member
Author
Are you sure about that? I mean, maybe the tools line, but are you sure you want infra to be pinged for the template.html file or the asset files? I'm updating this because the ping on #49882 didn't happen and that seems more like a website issue than an infra issue. If you say I'm wrong, I'll make them all infra, but I would think it would be all website and maybe infra in addition on the tools one? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
That's fair. Let's keep for the template to the website and tooling to web-infra |
Sorry, something went wrong.
RaisinTen
approved these changes
Sep 27, 2023
tniessen
approved these changes
Sep 27, 2023
ovflowd
reviewed
Sep 27, 2023
Comment thread
.github/CODEOWNERS
Outdated
lpinca
approved these changes
Sep 27, 2023
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/49883 ✔ Done loading data for nodejs/node/pull/49883 ----------------------------------- PR info ------------------------------------ Title meta: update website team with new name (#49883) Author Rich Trott (@Trott) Branch Trott:codeowners -> nodejs:main Labels meta, fast-track, commit-queue-squash Commits 5 - meta: update website team with new name - Merge branch 'main' into codeowners - Merge branch 'main' into codeowners - Update .github/CODEOWNERS - Merge branch 'main' into codeowners Committers 2 - Rich Trott - GitHub PR-URL: https://github.com/nodejs/node/pull/49883 Reviewed-By: Yagiz Nizipli Reviewed-By: Antoine du Hamel Reviewed-By: Claudio Wunder Reviewed-By: Moshe Atlow Reviewed-By: Darshan Sen Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49883 Reviewed-By: Yagiz Nizipli Reviewed-By: Antoine du Hamel Reviewed-By: Claudio Wunder Reviewed-By: Moshe Atlow Reviewed-By: Darshan Sen Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - Update .github/CODEOWNERS ⚠ - Merge branch 'main' into codeowners ℹ This PR was created on Tue, 26 Sep 2023 18:28:51 GMT ✔ Approvals: 7 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49883#pullrequestreview-1644961950 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/49883#pullrequestreview-1645005247 ✔ - Claudio Wunder (@ovflowd): https://github.com/nodejs/node/pull/49883#pullrequestreview-1645020927 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49883#pullrequestreview-1645030663 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/49883#pullrequestreview-1645620447 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/49883#pullrequestreview-1647064713 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49883#pullrequestreview-1647488560 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6344268112 |
Sorry, something went wrong.
Pings for the website team aren't working because the team name changed but it did not get updated in CODEOWNERS. PR-URL: nodejs#49883 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
Pings for the website team aren't working because the team name changed but it did not get updated in CODEOWNERS. PR-URL: #49883 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
Pings for the website team aren't working because the team name changed but it did not get updated in CODEOWNERS. PR-URL: #49883 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
debadree25
pushed a commit
to debadree25/node
that referenced
this pull request
Apr 15, 2024
Pings for the website team aren't working because the team name changed but it did not get updated in CODEOWNERS. PR-URL: nodejs#49883 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Pings for the website team aren't working because the team name changed but it did not get updated in CODEOWNERS. PR-URL: nodejs/node#49883 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Pings for the website team aren't working because the team name changed but it did not get updated in CODEOWNERS. PR-URL: nodejs/node#49883 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pings for the website team aren't working because the team name changed but it did not get updated in CODEOWNERS.