test: deflake test-perf-hooks.js - #49892
Closed
joyeecheung wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Previously when checking the initial timing we did a lot of checks after accessing and copying timing.duration and before we check that timing.duration is roughly the same as performance.now(), which can lead to flakes if the overhead of the checking is big enough. Update the test to check timing.duration against performance.now() as soon as possible when it's copied instead of computed. :#
Copy link
Copy Markdown
Member
Author
|
We don't have shared library boxes for the stress tests so I only started the stress test on osx-11 PR: https://ci.nodejs.org/job/node-stress-single-test/450/ |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
19 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
atlowChemi
approved these changes
Sep 29, 2023
richardlau
approved these changes
Sep 29, 2023
joyeecheung
added a commit
that referenced
this pull request
Sep 29, 2023
Previously when checking the initial timing we did a lot of checks after accessing and copying timing.duration and before we check that timing.duration is roughly the same as performance.now(), which can lead to flakes if the overhead of the checking is big enough. Update the test to check timing.duration against performance.now() as soon as possible when it's copied instead of computed. :# PR-URL: #49892 Refs: nodejs/reliability#676 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Richard Lau <rlau@redhat.com>
Copy link
Copy Markdown
Member
Author
|
CI was green but the bot had trouble communicating the CI status back to GitHub. Landed manually in 4d0aeed |
Sorry, something went wrong.
31 tasks
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
Previously when checking the initial timing we did a lot of checks after accessing and copying timing.duration and before we check that timing.duration is roughly the same as performance.now(), which can lead to flakes if the overhead of the checking is big enough. Update the test to check timing.duration against performance.now() as soon as possible when it's copied instead of computed. :# PR-URL: #49892 Refs: nodejs/reliability#676 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Richard Lau <rlau@redhat.com>
debadree25
pushed a commit
to debadree25/node
that referenced
this pull request
Apr 15, 2024
Previously when checking the initial timing we did a lot of checks after accessing and copying timing.duration and before we check that timing.duration is roughly the same as performance.now(), which can lead to flakes if the overhead of the checking is big enough. Update the test to check timing.duration against performance.now() as soon as possible when it's copied instead of computed. :# PR-URL: nodejs#49892 Refs: nodejs/reliability#676 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95
pushed a commit
that referenced
this pull request
Feb 10, 2025
Previously when checking the initial timing we did a lot of checks after accessing and copying timing.duration and before we check that timing.duration is roughly the same as performance.now(), which can lead to flakes if the overhead of the checking is big enough. Update the test to check timing.duration against performance.now() as soon as possible when it's copied instead of computed. :# PR-URL: #49892 Refs: nodejs/reliability#676 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Richard Lau <rlau@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously when checking the initial timing we did a lot of checks after accessing and copying timing.duration and before we check that timing.duration is roughly the same as performance.now(), which can lead to flakes if the overhead of the checking is big enough. Update the test to check timing.duration against performance.now() as soon as possible when it's copied instead of computed.
Refs: nodejs/reliability#676