FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fs: improve error performance for `fdatasyncSync` by pluris · Pull Request #49898 · nodejs/node · GitHub

/ node Public

fs: improve error performance for fdatasyncSync - #49898

Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
pluris:perf/fdatasync
Oct 4, 2023
ConversationCommits (4)ChecksFiles changed
Merged

fs: improve error performance for fdatasyncSync#49898
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
pluris:perf/fdatasync

Conversation

pluris commented Sep 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor 
                                                      confidence improvement accuracy (*)   (**)   (***)
fs/bench_fdatasyncSync.js n=10000 type='existing'            ***      6.39 %       ±1.85% ±2.48%  ±3.25%
fs/bench_fdatasyncSync.js n=10000 type='non-existing'        ***    116.11 %       ±6.89% ±9.21% ±12.08%

Be aware that when doing many comparisons the risk of a false-positive result increases.
In this case, there are 2 comparisons, you can thus expect the following amount of false-positive results:
  0.10 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.02 false positives, when considering a   1% risk acceptance (**, ***),
  0.00 false positives, when considering a 0.1% risk acceptance (***)

Refs: nodejs/performance#106

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 27, 2023
anonrig approved these changes Sep 27, 2023
View reviewed changes
Comment thread src/node_file.cc Outdated
anonrig added request-ci Add this label to start a Jenkins CI on a PR. needs-benchmark-ci PR that need a benchmark CI run. performance Issues and PRs related to the performance of Node.js. labels Sep 27, 2023
pluris mentioned this pull request Sep 27, 2023
Closed
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2023

nodejs-github-bot commented Sep 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54302/

joyeecheung reviewed Sep 27, 2023
View reviewed changes

joyeecheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't think we should introduce a seemingly new implementation by copying and repeating the original implementation & moving code to a new JS file which makes git blame harder to use. See #49593 (comment)

anonrig mentioned this pull request Sep 28, 2023
Open
github-actions Bot mentioned this pull request Sep 30, 2023
Open
31 tasks

anonrig commented Sep 30, 2023

Copy link
Copy Markdown
Member

Hey @pluris can you rebase this pull request? You'll see that sync.js file is now removed and merged into lib/fs.js

pluris force-pushed the perf/fdatasync branch 2 times, most recently from 358c67e to 78b27c0 Compare October 1, 2023 16:03

pluris commented Oct 1, 2023

Copy link
Copy Markdown
Contributor Author

@anonrig I rebased and applied #49913.

anonrig commented Oct 1, 2023

Copy link
Copy Markdown
Member

@anonrig I rebased and applied #49913.

Can you re-add the benchmark?

pluris commented Oct 1, 2023

Copy link
Copy Markdown
Contributor Author

@anonrig I updated the description.

                                                      confidence improvement accuracy (*)   (**)   (***)
fs/bench_fdatasyncSync.js n=10000 type='existing'                     1.12 %       ±1.51% ±2.01%  ±2.62%
fs/bench_fdatasyncSync.js n=10000 type='non-existing'        ***    109.42 %       ±6.13% ±8.19% ±10.73%

Be aware that when doing many comparisons the risk of a false-positive result increases.
In this case, there are 2 comparisons, you can thus expect the following amount of false-positive results:
  0.10 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.02 false positives, when considering a   1% risk acceptance (**, ***),
  0.00 false positives, when considering a 0.1% risk acceptance (***)

anonrig commented Oct 1, 2023

Copy link
Copy Markdown
Member

The benchmark you're running doesn't exist in main or in your pull request. Can you add the file to your pull request? :-) @pluris

pluris commented Oct 1, 2023

Copy link
Copy Markdown
Contributor Author

@anonrig Oh, sorry. I added it again.
I think I did something wrong during the rebase process. 😅

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2023
anonrig added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Oct 1, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2023

nodejs-github-bot commented Oct 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54446/

pluris commented Oct 1, 2023

Copy link
Copy Markdown
Contributor Author

Oops, there was a part where the condition check was missing, so I modified it again and updated the benchmark.

pluris commented Oct 2, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@joyeecheung GetValidatedFd() has also been removed here, as described in #49880 (explanation).

pluris requested a review from joyeecheung October 2, 2023 14:10
joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2023

nodejs-github-bot commented Oct 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54474/

github-actions Bot mentioned this pull request Oct 3, 2023
Open
18 tasks

nodejs-github-bot commented Oct 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54512/

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2023
github-actions Bot mentioned this pull request Oct 4, 2023
Open
14 tasks
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 4, 2023
nodejs-github-bot merged commit f7a160d into nodejs:main Oct 4, 2023

nodejs-github-bot commented Oct 4, 2023

Copy link
Copy Markdown
Collaborator

Landed in f7a160d

This was referenced Oct 5, 2023
Open
Open
RafaelGSS mentioned this pull request Oct 9, 2023
Merged
pluris deleted the perf/fdatasync branch November 8, 2023 02:24
targos pushed a commit that referenced this pull request Nov 11, 2023
fs: improve error performance for fdatasyncSync
d7132d9 
PR-URL: #49898
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos mentioned this pull request Nov 12, 2023
Merged
juanarbol mentioned this pull request Dec 6, 2023
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
fs: improve error performance for fdatasyncSync
4b7fc22 
PR-URL: nodejs#49898
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anonrig anonrig approved these changes
joyeecheung joyeecheung approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. lib / src Issues and PRs related to general changes in the lib or src directory. needs-benchmark-ci PR that need a benchmark CI run. needs-ci PRs that need a full CI run. performance Issues and PRs related to the performance of Node.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL