FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

perf_hooks: reduce overhead of new user timings by H4ad · Pull Request #49914 · nodejs/node · GitHub

/ node Public

perf_hooks: reduce overhead of new user timings - #49914

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
H4ad:perf/perf_hooks_usertiming
Oct 5, 2023
ConversationCommits (2)ChecksFiles changed
Merged

perf_hooks: reduce overhead of new user timings#49914
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
H4ad:perf/perf_hooks_usertiming

Conversation

H4ad commented Sep 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Continuing the work started on nodejs/performance#109.

This PR should be landed after #49837.

                                                    confidence improvement accuracy (*)    (**)   (***)
perf_hooks/usertiming.js observe='all' n=100000            ***    351.28 %       ±9.79% ±13.17% ±17.46%
perf_hooks/usertiming.js observe='measure' n=100000        ***    436.41 %       ±8.94% ±12.03% ±15.93%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 2 comparisons, you can thus
expect the following amount of false-positive results:
  0.10 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.02 false positives, when considering a   1% risk acceptance (**, ***),
  0.00 false positives, when considering a 0.1% risk acceptance (***)

I will use the changes on the latest PR to keep this even simpler, so I will keep as draft for now.

cc @nodejs/performance

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 28, 2023
H4ad force-pushed the perf/perf_hooks_usertiming branch from f6ff458 to 5fd5fad Compare October 1, 2023 14:29
H4ad marked this pull request as ready for review October 1, 2023 14:30
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2023

nodejs-github-bot commented Oct 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54443/

benjamingr reviewed Oct 1, 2023
View reviewed changes
Comment thread lib/internal/perf/usertiming.js Outdated
benjamingr approved these changes Oct 1, 2023
View reviewed changes

benjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

gj

H4ad force-pushed the perf/perf_hooks_usertiming branch from df6db01 to 41a0fdf Compare October 1, 2023 16:16
github-actions Bot mentioned this pull request Oct 2, 2023
Open
12 tasks
anonrig added performance Issues and PRs related to the performance of Node.js. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 2, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2023

nodejs-github-bot commented Oct 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54466/

github-actions Bot mentioned this pull request Oct 3, 2023
Open
18 tasks

nodejs-github-bot commented Oct 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54515/

github-actions Bot mentioned this pull request Oct 4, 2023
Open
14 tasks

nodejs-github-bot commented Oct 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54518/

github-actions Bot mentioned this pull request Oct 5, 2023
Open
13 tasks

nodejs-github-bot commented Oct 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54554/

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2023
nodejs-github-bot merged commit 0e507d3 into nodejs:main Oct 5, 2023

nodejs-github-bot commented Oct 5, 2023

Copy link
Copy Markdown
Collaborator

Landed in 0e507d3

H4ad deleted the perf/perf_hooks_usertiming branch October 5, 2023 11:28
RafaelGSS mentioned this pull request Oct 9, 2023
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
perf_hooks: reduce overhead of new user timings
e8f024b 
PR-URL: #49914
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
targos mentioned this pull request Nov 12, 2023
Merged
juanarbol mentioned this pull request Dec 6, 2023
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
perf_hooks: reduce overhead of new user timings
7665ea7 
PR-URL: nodejs#49914
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Qard Qard approved these changes
benjamingr benjamingr approved these changes
anonrig anonrig approved these changes
+1 more reviewer
sheplu sheplu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. performance Issues and PRs related to the performance of Node.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL