FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test_runner: add test location for FileTests by cjihrig · Pull Request #49999 · nodejs/node · GitHub

/ node Public

test_runner: add test location for FileTests - #49999

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
cjihrig:file-test-location
Oct 3, 2023
Merged

test_runner: add test location for FileTests#49999
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
cjihrig:file-test-location

Conversation

cjihrig commented Oct 1, 2023

Copy link
Copy Markdown
Contributor

This commit adds the previously missing test location for FileTest tests.

Fixes: #49926
Fixes: #49927

This commit adds the previously missing test location for
FileTest tests.

Fixes: nodejs#49926
Fixes: nodejs#49927
cjihrig requested a review from MoLow October 1, 2023 17:41

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Oct 1, 2023

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Oct 3, 2023
edited by cjihrig
Loading

Copy link
Copy Markdown
Collaborator

cjihrig added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Oct 3, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2023
nodejs-github-bot merged commit 4b35a9c into nodejs:main Oct 3, 2023

Copy link
Copy Markdown
Collaborator

Landed in 4b35a9c

cjihrig deleted the file-test-location branch October 3, 2023 18:19
targos pushed a commit that referenced this pull request Nov 11, 2023
This commit adds the previously missing test location for
FileTest tests.

Fixes: #49926
Fixes: #49927
PR-URL: #49999
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Nov 27, 2023
This commit adds the previously missing test location for
FileTest tests.

Fixes: #49926
Fixes: #49927
PR-URL: #49999
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
This commit adds the previously missing test location for
FileTest tests.

Fixes: nodejs#49926
Fixes: nodejs#49927
PR-URL: nodejs#49999
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
This commit adds the previously missing test location for
FileTest tests.

Fixes: nodejs/node#49926
Fixes: nodejs/node#49927
PR-URL: nodejs/node#49999
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
This commit adds the previously missing test location for
FileTest tests.

Fixes: nodejs/node#49926
Fixes: nodejs/node#49927
PR-URL: nodejs/node#49999
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

6 participants


Back | FazBrowse Home | New Git URL