esm: bypass CJS loader in default load under --default-type=module - #50004
esm: bypass CJS loader in default load under --default-type=module#50004aduh95 merged 4 commits into
Conversation
Sorry, something went wrong.
|
Review requested:
|
Sorry, something went wrong.
GeoffreyBooth
left a comment
There was a problem hiding this comment.
I like it. I would maybe rephrase the PR description though, I think this more a continued expansion of the behavior of --default-type to mean “in module mode, the ESM loader is the only loader in use” which is what we want and was part of the proposal.
Sorry, something went wrong.
There was a problem hiding this comment.
CJS .js files . . . that are required?
Sorry, something went wrong.
There was a problem hiding this comment.
that are required, imported, or used as entry point
Sorry, something went wrong.
There was a problem hiding this comment.
Might be worth spelling that out, I was assuming “CJS .js files” meant .js files required by CommonJS modules, rather than what I now presume you meant, “.js file that is interpreted as CommonJS.”
Sorry, something went wrong.
This allows user to opt-out from using the monkey-patchable CJS loader, even to load CJS modules.
Sorry, something went wrong.
Sorry, something went wrong.
This allows user to opt-out from using the monkey-patchable CJS loader, even to load CJS modules. PR-URL: #50004 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
This allows user to opt-out from using the monkey-patchable CJS loader, even to load CJS modules. PR-URL: #50004 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
This allows user to opt-out from using the monkey-patchable CJS loader, even to load CJS modules. PR-URL: #50004 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
This allows user to opt-out from using the monkey-patchable CJS loader to load CJS modules.