FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fs,url: refactor `FileURLToPath` and `FromNamespacedPath` by anonrig · Pull Request #50090 · nodejs/node · GitHub

/ node Public

fs,url: refactor FileURLToPath and FromNamespacedPath - #50090

Closed
anonrig wants to merge 3 commits into
nodejs:mainfrom
anonrig:refactor-file-url-to-path
ConversationCommits (3)ChecksFiles changed
Closed

fs,url: refactor FileURLToPath and FromNamespacedPath#50090
anonrig wants to merge 3 commits into
nodejs:mainfrom
anonrig:refactor-file-url-to-path

Conversation

anonrig commented Oct 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Moves FileURLToPath and FromNamespacedPath to node_url.cc and changes the function declarations

nodejs-github-bot commented Oct 8, 2023 •
edited by anonrig
Loading

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/url
  • @nodejs/fs
  • @nodejs/cpp-reviewers
  • @nodejs/performance

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 8, 2023
anonrig force-pushed the refactor-file-url-to-path branch from 0c45748 to f15ab36 Compare October 8, 2023 18:43
lemire reviewed Oct 8, 2023
View reviewed changes
Comment thread src/node_url.cc Outdated
anonrig commented Oct 8, 2023
View reviewed changes
Comment thread src/node_url.cc Outdated

GeoffreyBooth commented Oct 8, 2023

Copy link
Copy Markdown
Member

Does this just move, or move and refactor? If the latter could you please do that in two commits that we can land via commit-queue-rebase, so that we preserve the history of the refactor separately from the move.

anonrig force-pushed the refactor-file-url-to-path branch from f15ab36 to a8cbc30 Compare October 9, 2023 15:48
anonrig changed the title url: refactor FileURLToPath fs,url: refactor FileURLToPath and FromNamespacedPath Oct 9, 2023
anonrig added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Oct 9, 2023
anonrig force-pushed the refactor-file-url-to-path branch from a8cbc30 to a4ae983 Compare October 9, 2023 15:52
GeoffreyBooth approved these changes Oct 9, 2023
View reviewed changes

GeoffreyBooth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

anonrig force-pushed the refactor-file-url-to-path branch 2 times, most recently from a645373 to 3abddc7 Compare October 9, 2023 19:52
mcollina approved these changes Oct 9, 2023
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

anonrig added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 9, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2023

nodejs-github-bot commented Oct 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54638/

github-actions Bot mentioned this pull request Oct 10, 2023
Open
24 tasks

nodejs-github-bot commented Oct 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54641/

nodejs-github-bot commented Oct 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54651/

anonrig force-pushed the refactor-file-url-to-path branch from 3abddc7 to dc27ae3 Compare October 10, 2023 13:34

anonrig commented Oct 10, 2023

Copy link
Copy Markdown
Member Author

Rebased and force-pushed.

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2023

nodejs-github-bot commented Oct 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54658/

github-actions Bot mentioned this pull request Oct 25, 2023
Open
16 tasks
anonrig force-pushed the refactor-file-url-to-path branch from 9a2cd4c to 4bef812 Compare October 25, 2023 22:09
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2023
anonrig mentioned this pull request Oct 25, 2023
Closed
8 tasks
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2023

nodejs-github-bot commented Oct 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55239/

github-actions Bot mentioned this pull request Oct 26, 2023
Open
20 tasks

nodejs-github-bot commented Oct 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55242/

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2023

nodejs-github-bot commented Oct 26, 2023

Copy link
Copy Markdown
Collaborator

Landed in 9c714d8...b24215e

nodejs-github-bot pushed a commit that referenced this pull request Oct 26, 2023
fs,url: move FileURLToPath to node_url
557f928 
PR-URL: #50090
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
nodejs-github-bot pushed a commit that referenced this pull request Oct 26, 2023
fs,url: refactor FileURLToPath method
f0995d1 
PR-URL: #50090
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
nodejs-github-bot pushed a commit that referenced this pull request Oct 26, 2023
fs,url: move FromNamespacedPath to node_url
b24215e 
PR-URL: #50090
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
fs,url: move FileURLToPath to node_url
4345ee2 
PR-URL: #50090
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
fs,url: refactor FileURLToPath method
b4db32e 
PR-URL: #50090
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
fs,url: move FromNamespacedPath to node_url
67cbe1b 
PR-URL: #50090
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
targos mentioned this pull request Nov 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
fs,url: move FileURLToPath to node_url
186e6e0 
PR-URL: #50090
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
fs,url: refactor FileURLToPath method
de7fe08 
PR-URL: #50090
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
fs,url: move FromNamespacedPath to node_url
868a464 
PR-URL: #50090
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
UlisesGascon mentioned this pull request Dec 12, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
Qard Qard approved these changes
lemire lemire approved these changes
GeoffreyBooth GeoffreyBooth approved these changes
H4ad H4ad approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL