FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fs: improve error performance of readvSync by IlyasShabi · Pull Request #50100 · nodejs/node · GitHub

/ node Public

fs: improve error performance of readvSync - #50100

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
IlyasShabi:readv-sync
Dec 5, 2023
ConversationCommits (1)ChecksFiles changed
Merged

fs: improve error performance of readvSync#50100
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
IlyasShabi:readv-sync

Conversation

IlyasShabi commented Oct 9, 2023

Copy link
Copy Markdown
Member

Local benchmark:

                                                   confidence improvement accuracy (*)    (**)   (***)
fs/bench-readvSync.js n=100000 type='invalid'             ***    123.02 %       ±1.27%  ±1.70%  ±2.24%
fs/bench-readvSync.js n=100000 type='valid'                        2.74 %       ±2.88%  ±3.84%  ±5.01%

Ref: nodejs/performance#106

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Oct 9, 2023
anonrig reviewed Oct 9, 2023
View reviewed changes
Comment thread src/node_file.cc Outdated
anonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Oct 10, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2023

nodejs-github-bot commented Oct 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54643/

anonrig mentioned this pull request Oct 10, 2023
Open
github-actions Bot mentioned this pull request Oct 11, 2023
Open
30 tasks

anonrig commented Oct 13, 2023

Copy link
Copy Markdown
Member

Can you rebase and force push?

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 20, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 20, 2023

nodejs-github-bot commented Oct 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55073/

This was referenced Oct 22, 2023
Open
Open

nodejs-github-bot commented Oct 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55155/

This was referenced Oct 24, 2023
Open
Open
aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2023

nodejs-github-bot commented Nov 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56001/

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 5, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 5, 2023
nodejs-github-bot merged commit 27b2ce5 into nodejs:main Dec 5, 2023

nodejs-github-bot commented Dec 5, 2023

Copy link
Copy Markdown
Collaborator

Landed in 27b2ce5

RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
fs: improve error performance of readvSync
3f7f3ce 
PR-URL: #50100
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS mentioned this pull request Dec 15, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
fs: improve error performance of readvSync
6764f0c 
PR-URL: #50100
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
richardlau mentioned this pull request Mar 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anonrig anonrig approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL