FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: reduce overhead of transfer by H4ad · Pull Request #50107 · nodejs/node · GitHub

/ node Public

stream: reduce overhead of transfer - #50107

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
H4ad:perf/webstreams_writable
Oct 12, 2023
ConversationCommits (1)ChecksFiles changed
Merged

stream: reduce overhead of transfer#50107
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
H4ad:perf/webstreams_writable

Conversation

H4ad commented Oct 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Continuing the work started on nodejs/performance#109

                                                            confidence improvement accuracy (*)   (**)  (***)
webstreams/js_transfer.js n=10000 payload='ReadableStream'         ***     19.68 %       ±1.77% ±2.35% ±3.06%
webstreams/js_transfer.js n=10000 payload='TransformStream'        ***     18.80 %       ±1.76% ±2.35% ±3.06%
webstreams/js_transfer.js n=10000 payload='WritableStream'         ***     13.36 %       ±1.73% ±2.30% ±3.00%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 3 comparisons, you can thus
expect the following amount of false-positive results:
  0.15 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.03 false positives, when considering a   1% risk acceptance (**, ***),
  0.00 false positives, when considering a 0.1% risk acceptance (***)

/cc @nodejs/performance

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 9, 2023
H4ad force-pushed the perf/webstreams_writable branch from bc826eb to b0b5614 Compare October 10, 2023 12:15
H4ad marked this pull request as ready for review October 10, 2023 12:16
H4ad force-pushed the perf/webstreams_writable branch from 578d490 to d2e73bc Compare October 10, 2023 12:20
H4ad force-pushed the perf/webstreams_writable branch from d2e73bc to 68b0d91 Compare October 10, 2023 12:22
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2023
mcollina approved these changes Oct 10, 2023
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

H4ad commented Oct 10, 2023
View reviewed changes
Comment thread lib/internal/webstreams/readablestream.js
Comment on lines +654 to +657
writable: undefined,
port1: undefined,
port2: undefined,
promise: undefined,

H4ad Oct 10, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

For these properties, I followed what I saw in the constructor, the old version was wrong, right?

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2023

nodejs-github-bot commented Oct 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54652/

anonrig changed the title perf: webstreams transfer stream: reduce overhead of transfer Oct 10, 2023

nodejs-github-bot commented Oct 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54678/

github-actions Bot mentioned this pull request Oct 11, 2023
Open
30 tasks
mcollina approved these changes Oct 11, 2023
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

H4ad commented Oct 12, 2023

Copy link
Copy Markdown
Member Author

Someone can add author ready?

anonrig added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 12, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2023
nodejs-github-bot merged commit a85e418 into nodejs:main Oct 12, 2023

nodejs-github-bot commented Oct 12, 2023

Copy link
Copy Markdown
Collaborator

Landed in a85e418

H4ad deleted the perf/webstreams_writable branch October 12, 2023 14:42
RafaelGSS mentioned this pull request Oct 15, 2023
Merged
MattiasBuelens mentioned this pull request May 1, 2024
Merged
MattiasBuelens mentioned this pull request May 1, 2024
Closed
targos mentioned this pull request Sep 19, 2024
Closed
avivkeller mentioned this pull request Sep 21, 2024
Closed
jazelly mentioned this pull request Sep 22, 2024
Merged
nodejs-github-bot pushed a commit that referenced this pull request Sep 24, 2024
stream: set stream prototype to closest transferable superclass
0e52836 
PR-URL: #55067
Fixes: #54603
Refs: #50107
Reviewed-By: Mattias Buelens <mattias@buelens.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Oct 4, 2024
stream: set stream prototype to closest transferable superclass
bf69ae1 
PR-URL: #55067
Fixes: #54603
Refs: #50107
Reviewed-By: Mattias Buelens <mattias@buelens.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
Qard Qard approved these changes
anonrig anonrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL