FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

module: add application/json to accept header when fetching json module by marco-ippolito · Pull Request #50119 · nodejs/node · GitHub

/ node Public

module: add application/json to accept header when fetching json module - #50119

Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
marco-ippolito:feat/accept
Oct 30, 2023
ConversationCommits (4)ChecksFiles changed
Merged

module: add application/json to accept header when fetching json module#50119
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
marco-ippolito:feat/accept

Conversation

marco-ippolito commented Oct 10, 2023

Copy link
Copy Markdown
Member

Refs: #50116

nodejs-github-bot commented Oct 10, 2023 •
edited by marco-ippolito
Loading

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Oct 10, 2023
marco-ippolito force-pushed the feat/accept branch 2 times, most recently from 2d22e69 to af0919f Compare October 10, 2023 10:52
benjamingr reviewed Oct 10, 2023
View reviewed changes
Comment thread lib/internal/modules/esm/fetch_module.js Outdated
marco-ippolito added the wip Issues and PRs that are still a work in progress. label Oct 10, 2023
marco-ippolito force-pushed the feat/accept branch 4 times, most recently from cca1ab5 to ee25f49 Compare October 10, 2023 12:31
marco-ippolito removed the wip Issues and PRs that are still a work in progress. label Oct 10, 2023

aduh95 commented Oct 10, 2023

Copy link
Copy Markdown
Contributor

We should probably wait for whatwg/html#9486 to be merged, right?

nicolo-ribaudo mentioned this pull request Oct 11, 2023
Closed

marco-ippolito commented Oct 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

blocked by #50140

marco-ippolito assigned aduh95 and unassigned aduh95 Oct 14, 2023
marco-ippolito requested a review from aduh95 October 14, 2023 08:11
JakobJingleheimer approved these changes Oct 18, 2023
View reviewed changes

JakobJingleheimer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🙌

Is Antoine's comment still valid? #50119 (comment)

marco-ippolito commented Oct 18, 2023

Copy link
Copy Markdown
Member Author

I guess its ok to wait, but it wouldnt have any backdraw if we merged

jasnell reviewed Oct 28, 2023
View reviewed changes
Comment thread test/es-module/test-http-imports.mjs Outdated

nicolo-ribaudo commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

The spec has been merged.

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2023

nodejs-github-bot commented Oct 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55328/

marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed needs-ci PRs that need a full CI run. labels Oct 30, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 30, 2023
nodejs-github-bot merged commit 8d40818 into nodejs:main Oct 30, 2023

nodejs-github-bot commented Oct 30, 2023

Copy link
Copy Markdown
Collaborator

Landed in 8d40818

targos pushed a commit that referenced this pull request Nov 11, 2023
module: add application/json in accept header when fetching json module
66d793d 
PR-URL: #50119
Refs: #50116
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
module: add application/json in accept header when fetching json module
667d245 
PR-URL: #50119
Refs: #50116
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
module: add application/json in accept header when fetching json module
fffc495 
PR-URL: #50119
Refs: #50116
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
UlisesGascon mentioned this pull request Dec 12, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjamingr benjamingr approved these changes
JakobJingleheimer JakobJingleheimer approved these changes
aduh95 aduh95 approved these changes
jasnell Awaiting requested review from jasnell

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. esm Issues and PRs related to the ECMAScript Modules implementation. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL