doc: add information about Node-API versions >=9 - #50168
Closed
mhdawson wants to merge 15 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: Michael Dawson <midawson@redhat.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@legendecas can you review to confirm I've gotten this correct. |
Sorry, something went wrong.
vmoroz
reviewed
Oct 12, 2023
Comment thread
doc/api/n-api.md
Outdated
vmoroz
reviewed
Oct 12, 2023
Comment thread
doc/api/n-api.md
Outdated
vmoroz
reviewed
Oct 12, 2023
Comment thread
doc/api/n-api.md
Outdated
Signed-off-by: Michael Dawson <midawson@redhat.com>
legendecas
approved these changes
Oct 15, 2023
Mifrill
reviewed
Oct 17, 2023
Comment thread
doc/api/n-api.md
Outdated
Co-authored-by: Alex Strizhak <alexei.mifrill.strizhak@gmail.com>
Comment thread
doc/api/n-api.md
Outdated
Comment thread
doc/api/n-api.md
Outdated
Comment thread
doc/api/n-api.md
Outdated
Comment thread
doc/api/n-api.md
Outdated
Comment thread
doc/api/n-api.md
Outdated
Comment thread
doc/api/n-api.md
Outdated
Comment thread
doc/api/n-api.md
Outdated
Comment thread
doc/api/n-api.md
Outdated
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Copy link
Copy Markdown
Member
Author
|
@gabrielschulhof thanks for the suggestions, pulled them all in. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@gabrielschulhof @vmoroz believe it is ready for rev-review. |
Sorry, something went wrong.
legendecas
approved these changes
Oct 25, 2023
legendecas
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Still LGTM
Sorry, something went wrong.
mhdawson
added a commit
that referenced
this pull request
Oct 25, 2023
Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #50168 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #50168 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #50168 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.