fs: do not throw error on cpSync internals - #50185
Merged
nodejs-github-bot merged 1 commit intoOct 23, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
GeoffreyBooth
approved these changes
Oct 15, 2023
Copy link
Copy Markdown
Member
Author
|
cc @nodejs/fs |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/50185 ✔ Done loading data for nodejs/node/pull/50185 ----------------------------------- PR info ------------------------------------ Title fs: do not throw error on cpSync internals (#50185) Author Yagiz Nizipli (@anonrig) Branch anonrig:fs-cpsync -> nodejs:main Labels fs, author ready, needs-ci, review wanted Commits 1 - fs: do not throw error on cpSync internals Committers 1 - Yagiz Nizipli PR-URL: https://github.com/nodejs/node/pull/50185 Reviewed-By: Geoffrey Booth ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50185 Reviewed-By: Geoffrey Booth -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 14 Oct 2023 19:12:52 GMT ✔ Approvals: 1 ✔ - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/50185#pullrequestreview-1678792743 ✘ This PR needs to wait 27 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-10-15T12:24:28Z: https://ci.nodejs.org/job/node-test-pull-request/54816/ - Querying data for job/node-test-pull-request/54816/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6589859611 |
Sorry, something went wrong.
aduh95
approved these changes
Oct 23, 2023
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50185 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
PR-URL: #50185 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we have throwIfNoEntry flag in statSync right now, we can use it to avoid having try/catch blocks in cpSync.