Fix in crypto.markdown - #5019
Closed
Necromos wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
crypto.pbkdf2sync -> crypto.pbkdf2Sync
Copy link
Copy Markdown
Contributor
|
LGTM. Can you please fix the commit title like suggested in this section https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM with commit log change |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@thealphanerd Nope. I am not sure why @Necromos closed it. @Necromos Can we help you with this? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I landed the oldest open PR now: 7e51966 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crypto.pbkdf2sync -> crypto.pbkdf2Sync