stream: refactor writable _write - #50198
Merged
nodejs-github-bot merged 1 commit intoOct 24, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
anonrig
approved these changes
Oct 16, 2023
marco-ippolito
approved these changes
Oct 16, 2023
mcollina
approved these changes
Oct 17, 2023
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
ronag
commented
Oct 17, 2023
Comment thread
test/parallel/test-stream-uint8array.js
Outdated
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
@mcollina wdyt?
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Oct 19, 2023
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/50198 ✔ Done loading data for nodejs/node/pull/50198 ----------------------------------- PR info ------------------------------------ Title stream: refactor writable _write (#50198) Author Robert Nagy (@ronag) Branch ronag:writable-clean -> nodejs:main Labels author ready, needs-ci Commits 1 - stream: refactor writable _write Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/50198 Reviewed-By: Yagiz Nizipli Reviewed-By: Marco Ippolito Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50198 Reviewed-By: Yagiz Nizipli Reviewed-By: Marco Ippolito Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - stream: refactor writable _write ℹ This PR was created on Mon, 16 Oct 2023 13:34:39 GMT ✔ Approvals: 3 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50198#pullrequestreview-1680096270 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/50198#pullrequestreview-1680107397 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/50198#pullrequestreview-1681609596 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-10-18T13:41:53Z: https://ci.nodejs.org/job/node-test-pull-request/54940/ - Querying data for job/node-test-pull-request/54940/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6597965086 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@ronag can you please rebase to fix the git conflicts? |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
27 tasks
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/50198 ✔ Done loading data for nodejs/node/pull/50198 ----------------------------------- PR info ------------------------------------ Title stream: refactor writable _write (#50198) Author Robert Nagy (@ronag) Branch ronag:writable-clean -> nodejs:main Labels author ready, needs-ci Commits 1 - stream: refactor writable _write Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/50198 Reviewed-By: Yagiz Nizipli Reviewed-By: Marco Ippolito Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50198 Reviewed-By: Yagiz Nizipli Reviewed-By: Marco Ippolito Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - stream: refactor writable _write ℹ This PR was created on Mon, 16 Oct 2023 13:34:39 GMT ✔ Approvals: 3 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50198#pullrequestreview-1680096270 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/50198#pullrequestreview-1680107397 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/50198#pullrequestreview-1681609596 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-10-23T21:53:15Z: https://ci.nodejs.org/job/node-test-pull-request/55168/ - Querying data for job/node-test-pull-request/55168/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6623263972 |
Sorry, something went wrong.
anonrig
approved these changes
Oct 24, 2023
This was referenced Oct 25, 2023
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50198 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
PR-URL: #50198 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up the implementation a bit to make future work easier.