stream: avoid getter for defaultEncoding - #50203
Merged
nodejs-github-bot merged 1 commit intoOct 23, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
anonrig
reviewed
Oct 16, 2023
Comment thread
lib/internal/streams/writable.js
Outdated
meyfa
reviewed
Oct 16, 2023
Comment thread
lib/internal/streams/writable.js
Outdated
mcollina
approved these changes
Oct 17, 2023
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
benjamingr
approved these changes
Oct 17, 2023
ronag
force-pushed
the
writable-default-encoding
branch
from
afbc8dc to
ada4899
Compare
October 17, 2023 17:46
anonrig
approved these changes
Oct 17, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Oct 17, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
ronag
force-pushed
the
writable-default-encoding
branch
from
9493b26 to
e05f661
Compare
October 18, 2023 09:27
pacifiquem
reviewed
Oct 18, 2023
pacifiquem
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
LGTM 👍
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
20 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/50203 ✔ Done loading data for nodejs/node/pull/50203 ----------------------------------- PR info ------------------------------------ Title stream: avoid getter for defaultEncoding (#50203) Author Robert Nagy (@ronag) Branch ronag:writable-default-encoding -> nodejs:main Labels author ready, needs-ci Commits 1 - stream: avoid getter for defaultEncoding Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/50203 Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50203 Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - stream: avoid getter for defaultEncoding ℹ This PR was created on Mon, 16 Oct 2023 18:49:29 GMT ✔ Approvals: 4 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/50203#pullrequestreview-1681620676 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/50203#pullrequestreview-1682971946 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50203#pullrequestreview-1683007855 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50203#pullrequestreview-1683084786 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-10-21T19:06:08Z: https://ci.nodejs.org/job/node-test-pull-request/55103/ - Querying data for job/node-test-pull-request/55103/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6599503281 |
Sorry, something went wrong.
This was referenced Oct 22, 2023
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/50203 ✔ Done loading data for nodejs/node/pull/50203 ----------------------------------- PR info ------------------------------------ Title stream: avoid getter for defaultEncoding (#50203) Author Robert Nagy (@ronag) Branch ronag:writable-default-encoding -> nodejs:main Labels author ready, needs-ci Commits 1 - stream: avoid getter for defaultEncoding Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/50203 Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50203 Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - stream: avoid getter for defaultEncoding ℹ This PR was created on Mon, 16 Oct 2023 18:49:29 GMT ✔ Approvals: 4 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/50203#pullrequestreview-1681620676 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/50203#pullrequestreview-1682971946 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50203#pullrequestreview-1683007855 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50203#pullrequestreview-1683084786 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-10-21T20:28:41Z: https://ci.nodejs.org/job/node-test-pull-request/55103/ - Querying data for job/node-test-pull-request/55103/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6609871118 |
Sorry, something went wrong.
mcollina
approved these changes
Oct 23, 2023
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
27 tasks
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50203 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
PR-URL: #50203 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.