FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: update api `stream.compose` by himself65 · Pull Request #50206 · nodejs/node · GitHub

/ node Public

docs: update api stream.compose - #50206

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
himself65:himself65/1014/docs-update
Oct 19, 2023
ConversationCommits (1)ChecksFiles changed
Merged

docs: update api stream.compose#50206
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
himself65:himself65/1014/docs-update

Conversation

himself65 commented Oct 16, 2023

Copy link
Copy Markdown
Member

nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Oct 16, 2023
himself65 force-pushed the himself65/1014/docs-update branch 2 times, most recently from 407468c to 3cfa55c Compare October 16, 2023 22:53
himself65 force-pushed the himself65/1014/docs-update branch from 01d7a5e to 10789bf Compare October 16, 2023 23:58
Mifrill reviewed Oct 17, 2023
View reviewed changes
Comment thread doc/api/stream.md

* `streams` {Stream\[]|Iterable\[]|AsyncIterable\[]|Function\[]|
ReadableStream\[]|WritableStream\[]|TransformStream\[]}
ReadableStream\[]|WritableStream\[]|TransformStream\[]|Duplex\[]|Function}

Mifrill Oct 17, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

How about additionally including various types of streams such as Transform, PassThrough, FileReadStream, FileWriteStream, and Socket, allowing for more comprehensive coverage of stream types?

Suggested change
ReadableStream\[]|WritableStream\[]|TransformStream\[]|Duplex\[]|Function}
ReadableStream\[]|WritableStream\[]|TransformStream\[]|Duplex\[]|Function|Transform\[]|PassThrough\[]| FileReadStream\[]|FileWriteStream\[]|Socket\[]}

himself65 Oct 17, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think other document doesn't have such classes. Also I think current classes are top-level class, we don't need add all of the builtin class stuff

himself65 added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 17, 2023

github-actions Bot commented Oct 17, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @himself65. Please 👍 to approve.

H4ad added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 18, 2023
himself65 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2023
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 18, 2023

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/50206
✔  Done loading data for nodejs/node/pull/50206
----------------------------------- PR info ------------------------------------
Title      docs: update api `stream.compose` (#50206)
Author     Alex Yang  (@himself65)
Branch     himself65:himself65/1014/docs-update -> nodejs:main
Labels     doc, stream, fast-track, author ready
Commits    1
 - doc: update api `stream.compose`
Committers 1
 - Alex Yang 
PR-URL: https://github.com/nodejs/node/pull/50206
Refs: https://github.com/nodejs/node/pull/50187/files#r1361215879
Reviewed-By: Moshe Atlow 
Reviewed-By: Vinícius Lourenço Claro Cardoso 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50206
Refs: https://github.com/nodejs/node/pull/50187/files#r1361215879
Reviewed-By: Moshe Atlow 
Reviewed-By: Vinícius Lourenço Claro Cardoso 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 16 Oct 2023 22:50:21 GMT
   ✔  Approvals: 2
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/50206#pullrequestreview-1682063884
   ✔  - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/50206#pullrequestreview-1683690155
   ℹ  This PR is being fast-tracked
   ✘  This PR needs to wait 3 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6565350236

himself65 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 18, 2023
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 18, 2023

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/50206
✔  Done loading data for nodejs/node/pull/50206
----------------------------------- PR info ------------------------------------
Title      docs: update api `stream.compose` (#50206)
Author     Alex Yang  (@himself65)
Branch     himself65:himself65/1014/docs-update -> nodejs:main
Labels     doc, stream, fast-track, author ready
Commits    1
 - doc: update api `stream.compose`
Committers 1
 - Alex Yang 
PR-URL: https://github.com/nodejs/node/pull/50206
Refs: https://github.com/nodejs/node/pull/50187/files#r1361215879
Reviewed-By: Moshe Atlow 
Reviewed-By: Vinícius Lourenço Claro Cardoso 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50206
Refs: https://github.com/nodejs/node/pull/50187/files#r1361215879
Reviewed-By: Moshe Atlow 
Reviewed-By: Vinícius Lourenço Claro Cardoso 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 16 Oct 2023 22:50:21 GMT
   ✔  Approvals: 2
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/50206#pullrequestreview-1682063884
   ✔  - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/50206#pullrequestreview-1683690155
   ℹ  This PR is being fast-tracked
   ✘  This PR needs to wait 2 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6566227376

himself65 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 18, 2023
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 18, 2023

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/50206
✔  Done loading data for nodejs/node/pull/50206
----------------------------------- PR info ------------------------------------
Title      docs: update api `stream.compose` (#50206)
Author     Alex Yang  (@himself65)
Branch     himself65:himself65/1014/docs-update -> nodejs:main
Labels     doc, stream, fast-track, author ready
Commits    1
 - doc: update api `stream.compose`
Committers 1
 - Alex Yang 
PR-URL: https://github.com/nodejs/node/pull/50206
Refs: https://github.com/nodejs/node/pull/50187/files#r1361215879
Reviewed-By: Moshe Atlow 
Reviewed-By: Vinícius Lourenço Claro Cardoso 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50206
Refs: https://github.com/nodejs/node/pull/50187/files#r1361215879
Reviewed-By: Moshe Atlow 
Reviewed-By: Vinícius Lourenço Claro Cardoso 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 16 Oct 2023 22:50:21 GMT
   ✔  Approvals: 2
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/50206#pullrequestreview-1682063884
   ✔  - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/50206#pullrequestreview-1683690155
   ℹ  This PR is being fast-tracked
   ✘  This PR needs to wait 21 more minutes to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6567293855

himself65 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 19, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 19, 2023
nodejs-github-bot merged commit c016397 into nodejs:main Oct 19, 2023

nodejs-github-bot commented Oct 19, 2023

Copy link
Copy Markdown
Collaborator

Landed in c016397

himself65 deleted the himself65/1014/docs-update branch October 19, 2023 01:05
targos pushed a commit that referenced this pull request Oct 23, 2023
doc: update api stream.compose
ce9d84e 
PR-URL: #50206
Refs: https://github.com/nodejs/node/pull/50187/files#r1361215879
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
targos mentioned this pull request Oct 23, 2023
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
doc: update api stream.compose
4b50335 
PR-URL: #50206
Refs: https://github.com/nodejs/node/pull/50187/files#r1361215879
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
targos mentioned this pull request Nov 12, 2023
Merged
juanarbol mentioned this pull request Dec 6, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

MoLow MoLow approved these changes
H4ad H4ad approved these changes
+1 more reviewer
Mifrill Mifrill left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL